From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C1C514EC64 for ; Thu, 27 Jun 2024 15:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719501920; cv=none; b=WzDkhWuDO57flEdPAPUFG/4fA+TsbNgAlduvpICZ7U8VKVm9YAer3c2nHZWp/Rz7dqdoUK9sVDeBoiHilGIApmFFOzzrBnQOLcMydn16N85100JOunPmlbOUv9TgbxrgVpaWPVilIgBBjeXarHmFPpFQ0PH7X0oddiLk/PDmM90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719501920; c=relaxed/simple; bh=KMLjZIT1/+LEZM2TlXdwIk0EpfixpoY2KLbfpRu0jnU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZyUFnppq+fRGyudg/2DFrszoC2I6YLjmcF82Kv9waE83UL+GF0ONNBMJuOo5OHBhLoOggStiN4D26Txr9BtV3Ar9fsveH+058iNlD7EZdCF22cQjJ1NF7aOq0ktpELeXbswHNvjeODd8B+q5U/qqEfJQOLw5kWi6cSfEpnNxr4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 2DCFC68BFE; Thu, 27 Jun 2024 17:25:13 +0200 (CEST) Date: Thu, 27 Jun 2024 17:25:13 +0200 From: "hch@lst.de" To: Michael Kelley Cc: Petr =?utf-8?B?VGVzYcWZw61r?= , "hch@lst.de" , "robin.murphy@arm.com" , "joro@8bytes.org" , "will@kernel.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "oleksandr_tyshchenko@epam.com" , "m.szyprowski@samsung.com" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool() Message-ID: <20240627152513.GA23497@lst.de> References: <20240607031421.182589-1-mhklinux@outlook.com> <20240627060251.GA15590@lst.de> <20240627085216.556744c1@meshulam.tesarici.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Jun 27, 2024 at 02:59:03PM +0000, Michael Kelley wrote: > Conceptually, it's still being used as a boolean function based on > whether the return value is NULL. Renaming it to swiotlb_get_pool() > more accurately describes the return value, but obscures the > intent of determining if it is a swiotlb buffer. I'll think about it. > Suggestions are welcome. Just keep is_swiotlb_buffer as a trivial inline helper that returns bool.