Re: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool()

hch
2024-06-28T06:01:46Z

On Thu, Jun 27, 2024 at 04:02:59PM +0000, Michael Kelley wrote:
> > > Conceptually, it's still being used as a boolean function based on
> > > whether the return value is NULL. Renaming it to swiotlb_get_pool()
> > > more accurately describes the return value, but obscures the
> > > intent of determining if it is a swiotlb buffer. I'll think about it.
> > > Suggestions are welcome.
> >
> > Just keep is_swiotlb_buffer as a trivial inline helper that returns
> > bool.
>
> I don't understand what you are suggesting. Could you elaborate a bit?
> is_swiotlb_buffer() can't be trivial when CONFIG_SWIOTLB_DYNAMIC
> is set.

Call the main function that finds and retuns the pool swiotlb_find_pool,
and then have a is_swiotlb_buffer wrapper that just returns bool.