RE: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool()

Michael Kelley
2024-06-27T16:03:01Z

From: hch@lst.de <hch@lst.de> Sent: Thursday, June 27, 2024 8:25 AM
>
> On Thu, Jun 27, 2024 at 02:59:03PM +0000, Michael Kelley wrote:
> > Conceptually, it's still being used as a boolean function based on
> > whether the return value is NULL. Renaming it to swiotlb_get_pool()
> > more accurately describes the return value, but obscures the
> > intent of determining if it is a swiotlb buffer. I'll think about it.
> > Suggestions are welcome.
>
> Just keep is_swiotlb_buffer as a trivial inline helper that returns
> bool.

I don't understand what you are suggesting. Could you elaborate a bit?
is_swiotlb_buffer() can't be trivial when CONFIG_SWIOTLB_DYNAMIC
is set.

Michael