From: Rob Herring <robh@kernel.org>
To: Tomer Maimon <tmaimon77@gmail.com>
Cc: mturquette@baylibre.com, sboyd@kernel.org,
p.zabel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
yuenn@google.com, benjaminfair@google.com,
openbmc@lists.ozlabs.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v25 1/3] dt-bindings: reset: npcm: add clock properties
Date: Thu, 27 Jun 2024 15:07:38 -0600 [thread overview]
Message-ID: <20240627210738.GB501440-robh@kernel.org> (raw)
In-Reply-To: <20240618185819.2155595-2-tmaimon77@gmail.com>
On Tue, Jun 18, 2024 at 09:58:17PM +0300, Tomer Maimon wrote:
> This commit adds a 25MHz reference clock and clock-cell properties to
> the NPCM reset document. The addition is necessitated by the integration
> of the NPCM8xx clock auxiliary bus device into the NPCM reset driver.
>
> The inclusion of the NPCM8xx clock properties in the reset document is
> crucial as the reset block also serves as a clock provider for the
> NPCM8xx clock. This enhancement is intended to facilitate the use of the
> NPCM8xx clock driver.
Still not really much of an explanation of why an ABI break is okay.
Reasons are generally no one has the h/w yet, or the platform support is
incomplete and really doesn't work without DT updates.
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../bindings/reset/nuvoton,npcm750-reset.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
It's ultimately the platform's maintainers problem to care, so:
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2024-06-27 21:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 18:58 [PATCH v25 0/3] Introduce Nuvoton Arbel NPCM8XX BMC SoC Tomer Maimon
2024-06-18 18:58 ` [PATCH v25 1/3] dt-bindings: reset: npcm: add clock properties Tomer Maimon
2024-06-19 6:20 ` kernel test robot
2024-06-20 7:32 ` Tomer Maimon
2024-06-27 20:58 ` Rob Herring
2024-06-27 21:07 ` Rob Herring [this message]
2024-06-18 18:58 ` [PATCH v25 2/3] reset: npcm: register npcm8xx clock auxiliary bus device Tomer Maimon
2024-06-20 5:57 ` kernel test robot
2024-06-18 18:58 ` [PATCH v25 3/3] clk: npcm8xx: add clock controller Tomer Maimon
2024-06-25 18:19 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240627210738.GB501440-robh@kernel.org \
--to=robh@kernel.org \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox