From: "hch@lst.de" <hch@lst.de>
To: Michael Kelley <mhklinux@outlook.com>
Cc: "hch@lst.de" <hch@lst.de>, "Petr Tesařík" <petr@tesarici.cz>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"jgross@suse.com" <jgross@suse.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"oleksandr_tyshchenko@epam.com" <oleksandr_tyshchenko@epam.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool()
Date: Fri, 28 Jun 2024 08:01:29 +0200 [thread overview]
Message-ID: <20240628060129.GA26206@lst.de> (raw)
In-Reply-To: <SN6PR02MB4157D9B1A64FF78461D6A7EDD4D72@SN6PR02MB4157.namprd02.prod.outlook.com>
On Thu, Jun 27, 2024 at 04:02:59PM +0000, Michael Kelley wrote:
> > > Conceptually, it's still being used as a boolean function based on
> > > whether the return value is NULL. Renaming it to swiotlb_get_pool()
> > > more accurately describes the return value, but obscures the
> > > intent of determining if it is a swiotlb buffer. I'll think about it.
> > > Suggestions are welcome.
> >
> > Just keep is_swiotlb_buffer as a trivial inline helper that returns
> > bool.
>
> I don't understand what you are suggesting. Could you elaborate a bit?
> is_swiotlb_buffer() can't be trivial when CONFIG_SWIOTLB_DYNAMIC
> is set.
Call the main function that finds and retuns the pool swiotlb_find_pool,
and then have a is_swiotlb_buffer wrapper that just returns bool.
next prev parent reply other threads:[~2024-06-28 6:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 3:14 [RFC 1/1] swiotlb: Reduce calls to swiotlb_find_pool() mhkelley58
2024-06-26 23:58 ` Michael Kelley
2024-06-27 6:02 ` hch
2024-06-27 6:52 ` Petr Tesařík
2024-06-27 14:59 ` Michael Kelley
2024-06-27 15:25 ` hch
2024-06-27 16:02 ` Michael Kelley
2024-06-28 6:01 ` hch [this message]
2024-06-28 7:47 ` Petr Tesařík
2024-06-29 15:55 ` Michael Kelley
2024-06-30 5:55 ` hch
2024-06-30 14:02 ` Michael Kelley
2024-07-01 4:36 ` hch
2024-07-01 5:47 ` Petr Tesařík
2024-06-27 7:20 ` Petr Tesařík
2024-06-27 15:04 ` Michael Kelley
2024-06-29 15:53 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628060129.GA26206@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhklinux@outlook.com \
--cc=oleksandr_tyshchenko@epam.com \
--cc=petr@tesarici.cz \
--cc=robin.murphy@arm.com \
--cc=sstabellini@kernel.org \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox