Re: [PATCH V8 01/12] perf/core: Add aux_pause, aux_resume, aux_start_paused

Peter Zijlstra
2024-07-01T10:27:15Z

On Fri, Jun 28, 2024 at 09:51:00AM +0300, Adrian Hunter wrote:

> Add aux_paused to struct perf_event for AUX area events to keep track of
> the "paused" state. aux_paused is initialized to aux_start_paused.

> @@ -798,6 +810,9 @@ struct perf_event {
> /* for aux_output events */
> struct perf_event *aux_event;
>
> + /* for AUX area events */
> + unsigned int aux_paused;
> +
> void (*destroy)(struct perf_event *);
> struct rcu_head rcu_head;
>

Should this not be part of struct hw_perf_event for whatever hw event
implements this AUX stuff?

In fact, I would expect PERF_HES_PAUSED or something to go in
perf_event::hw::state.