From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2] drm/mipi-dsi: Add OF notifier handler
Date: Fri, 28 Jun 2024 12:31:40 +0200 [thread overview]
Message-ID: <20240628123140.5872fc6f@booty> (raw)
In-Reply-To: <20240627071904.4017160-1-wenst@chromium.org>
Hello Chen-Yu,
+Rob
On Thu, 27 Jun 2024 15:19:03 +0800
Chen-Yu Tsai <wenst@chromium.org> wrote:
> Add OF notifier handler needed for creating/destroying MIPI DSI devices
> according to dynamic runtime changes in the DT live tree. This code is
> enabled when CONFIG_OF_DYNAMIC is selected.
>
> This is based on existing code for I2C and SPI subsystems.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Thanks for copying me on this patch. Could be useful for my
hotplug-bridge work, however I'm aiming at writing code that works also
for non-DSI so we'll see. The code looks pretty fine however.
My concern however is about the usage of an OF reconfig notifier. A few
days ago Rob Herring wrote:
> a notifier is never a great design so
> maybe we can come up with something better
(https://lore.kernel.org/all/CAL_Jsq+=mGEJXsjq1UZFMJtHko_z+doiFMXnx9K7exDuznymSA@mail.gmail.com)
So maybe this is something you can clarify with him.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-06-28 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 7:19 [PATCH v2] drm/mipi-dsi: Add OF notifier handler Chen-Yu Tsai
2024-06-28 10:31 ` Luca Ceresoli [this message]
2024-07-04 7:04 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628123140.5872fc6f@booty \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox