Re: [PATCH v5 2/7] dt-bindings: mikrobus: Add mikrobus board base

Rob Herring
2024-06-28T16:04:39Z

On Thu, Jun 27, 2024 at 09:56:12PM +0530, Ayush Singh wrote:
> Base dt bindings for mikrobus addon boards. Contains properties that are
> part of all types of boards (SPI, I2C, etc).
>
> Each pin in mikroBUS connector can either be used for it's original
> purpose (UART, I2C, SPI, etc) or as a normal GPIO. Introducing
> `pinctrl-apply` allows selecting the pin configuration by name.

This seems pointless. If a board uses UART, then uart_default has to be
supported. Why does the board need to list it?

>
> Note: Some mikrobus-connectors might not support all valid pinctrl.
>
> Signed-off-by: Ayush Singh <ayush@beagleboard.org>
> ---
> .../devicetree/bindings/mikrobus/mikrobus-board.yaml | 20 ++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 21 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mikrobus/mikrobus-board.yaml b/Documentation/devicetree/bindings/mikrobus/mikrobus-board.yaml
> new file mode 100644
> index 000000000000..42e2219c596f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mikrobus/mikrobus-board.yaml
> @@ -0,0 +1,20 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mikrobus/mikrobus-board.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: mikroBUS add-on board properties
> +
> +maintainers:
> + - Ayush Singh <ayush@beagleboard.org>
> +
> +properties:
> + pinctrl-apply:

Missing a description.

> + minItems: 1
> + maxItems: 9
> + items:
> + enum: [default, pwm_default, pwm_gpio, uart_default, uart_gpio, i2c_default, i2c_gpio, spi_default,
> + spi_gpio]
> +
> +additionalProperties: false
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8e4115e93aeb..14eba18832d5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15113,6 +15113,7 @@ M: Ayush Singh <ayush@beagleboard.org>
> M: Vaishnav M A <vaishnav@beagleboard.org>
> S: Maintained
> F: Documentation/devicetree/bindings/connector/mikrobus-connector.yaml
> +F: Documentation/devicetree/bindings/mikrobus/mikrobus-board.yaml
>
> MIKROTIK CRS3XX 98DX3236 BOARD SUPPORT
> M: Luka Kovacic <luka.kovacic@sartura.hr>
>
> --
> 2.45.2
>