From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: X86 Kernel <x86@kernel.org>,
Sean Christopherson <seanjc@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>, "Xin Li" <xin3.li@intel.com>,
linux-perf-users@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Tony Luck <tony.luck@intel.com>,
Andy Lutomirski <luto@kernel.org>,
acme@kernel.org, kan.liang@linux.intel.com,
Andi Kleen <andi.kleen@intel.com>,
"Mehta, Sohil" <sohil.mehta@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [PATCH v3 01/11] x86/irq: Add enumeration of NMI source reporting CPU feature
Date: Fri, 28 Jun 2024 13:18:29 -0700 [thread overview]
Message-ID: <20240628201839.673086-2-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <20240628201839.673086-1-jacob.jun.pan@linux.intel.com>
The lack of a mechanism to pinpoint the origins of Non-Maskable Interrupts
(NMIs) necessitates that the NMI vector 2 handler consults each NMI source
handler individually. This approach leads to inefficiencies, delays, and
the occurrence of unnecessary NMIs, thereby also constraining the potential
applications of NMIs.
A new CPU feature, known as NMI source reporting, has been introduced as
part of the Flexible Return and Event Delivery (FRED) spec. This feature
enables the NMI vector 2 handler to directly obtain information about the
NMI source from the FRED event data.
The functionality of NMI source reporting is tied to the FRED. Although it
is enumerated by a unique CPUID feature bit, it cannot be turned off
independently once FRED is activated.
Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
---
v3: Removed CONFIG_X86_NMI_SOURCE (Li Xin, HPA, Sohil)
v2: Removed NMI source from static CPU ID dependency table (HPA)
---
arch/x86/include/asm/cpufeatures.h | 1 +
arch/x86/kernel/traps.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
index 3c7434329661..ec78d361e685 100644
--- a/arch/x86/include/asm/cpufeatures.h
+++ b/arch/x86/include/asm/cpufeatures.h
@@ -327,6 +327,7 @@
#define X86_FEATURE_FRED (12*32+17) /* Flexible Return and Event Delivery */
#define X86_FEATURE_LKGS (12*32+18) /* "" Load "kernel" (userspace) GS */
#define X86_FEATURE_WRMSRNS (12*32+19) /* "" Non-serializing WRMSR */
+#define X86_FEATURE_NMI_SOURCE (12*32+20) /* NMI source reporting */
#define X86_FEATURE_AMX_FP16 (12*32+21) /* "" AMX fp16 Support */
#define X86_FEATURE_AVX_IFMA (12*32+23) /* "" Support for VPMADD52[H,L]UQ */
#define X86_FEATURE_LAM (12*32+26) /* Linear Address Masking */
diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index 4fa0b17e5043..465f04e4a79f 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -1427,8 +1427,10 @@ early_param("fred", fred_setup);
void __init trap_init(void)
{
- if (cpu_feature_enabled(X86_FEATURE_FRED) && !enable_fred)
+ if (cpu_feature_enabled(X86_FEATURE_FRED) && !enable_fred) {
setup_clear_cpu_cap(X86_FEATURE_FRED);
+ setup_clear_cpu_cap(X86_FEATURE_NMI_SOURCE);
+ }
/* Init cpu_entry_area before IST entries are set up */
setup_cpu_entry_areas();
--
2.25.1
next prev parent reply other threads:[~2024-06-28 20:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 20:18 [PATCH v3 00/11] Add support for NMI source reporting Jacob Pan
2024-06-28 20:18 ` Jacob Pan [this message]
2024-06-28 20:18 ` [PATCH v3 02/11] x86/irq: Define NMI source vectors Jacob Pan
2024-06-29 18:32 ` Xin Li
2024-07-01 17:16 ` Jacob Pan
2024-06-28 20:18 ` [PATCH v3 03/11] x86/irq: Extend NMI handler registration interface to include source Jacob Pan
2024-06-28 20:18 ` [PATCH v3 04/11] x86/irq: Factor out common NMI handling code Jacob Pan
2024-06-29 0:31 ` Xin Li
2024-07-03 23:10 ` Jacob Pan
2024-06-28 20:18 ` [PATCH v3 05/11] x86/irq: Process nmi sources in NMI handler Jacob Pan
2024-06-29 3:39 ` Xin Li
2024-07-07 3:48 ` Jacob Pan
2024-07-01 14:31 ` Nikolay Borisov
2024-07-01 15:36 ` Jacob Pan
2024-06-28 20:18 ` [PATCH v3 06/11] KVM: VMX: Expand FRED kvm entry with event data Jacob Pan
2024-06-29 4:01 ` Xin Li
2024-07-01 15:39 ` Jacob Pan
2024-06-28 20:18 ` [PATCH v3 07/11] KVM: VMX: Handle NMI Source report in VM exit Jacob Pan
2024-06-29 4:07 ` Xin Li
2024-07-01 15:45 ` Jacob Pan
2024-07-01 17:03 ` Xin Li
2024-07-01 18:00 ` Jacob Pan
2024-06-30 13:04 ` Zeng Guang
2024-07-01 15:46 ` Jacob Pan
2024-06-28 20:18 ` [PATCH v3 08/11] perf/x86: Enable NMI source reporting for perfmon Jacob Pan
2024-07-04 14:44 ` Liang, Kan
2024-07-06 22:49 ` Jacob Pan
2024-06-28 20:18 ` [PATCH v3 09/11] x86/irq: Enable NMI source on IPIs delivered as NMI Jacob Pan
2024-06-28 20:18 ` [PATCH v3 10/11] x86/irq: Move __prepare_ICR to x86 common header Jacob Pan
2024-06-28 20:18 ` [PATCH v3 11/11] KVM: X86: Use common code for PV IPIs in linux guest Jacob Pan
2024-06-29 18:38 ` Xin Li
2024-07-01 16:38 ` Jacob Pan
2024-07-01 17:13 ` Xin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240628201839.673086-2-jacob.jun.pan@linux.intel.com \
--to=jacob.jun.pan@linux.intel.com \
--cc=acme@kernel.org \
--cc=andi.kleen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox