Re: [PATCH 2/2] lib/sort: Optimize heapsort with double-pop variation

Mario Limonciello
2024-06-20T20:17:08Z

On 6/20/2024 10:36, Julian Sikorski wrote:
> Hello,
>
> it appears that this patch has caused suspend-to-idle regression:
>
> https://gitlab.freedesktop.org/drm/amd/-/issues/3436
>
> In brief, my laptop fails to suspend completely with the following error
> in the log:
>
> Jun 18 12:42:20 kernel: amd_pmc AMDI0005:00: Last suspend didn't reach
> deepest state
>
> Power consumption remains high enough that my battery has already
> unexpectedly drained twice before I noticed something was off.
> I am not entirely sure how changes to sorting function can influence
> suspend, but it is what it is. 6.9.5 as shipped by Fedora 40 exhibits
> the issue, 6.9.5 as shipped by Fedora with the patch reverted does not.
>
> Best regards,
> Juliam
>

+regressions M/L

#regzbot ^introduced: 0e02ca29a563
#regzbot from: Kuan-Wei Chiu <visitorckw@gmail.com>
#regzbot monitor: https://gitlab.freedesktop.org/drm/amd/-/issues/3436