Re: [PATCH 2/2] lib/sort: Optimize heapsort with double-pop variation

Linux regression tracking (Thorsten Leemhuis)
2024-06-28T15:15:18Z

On 20.06.24 17:36, Julian Sikorski wrote:
>
> it appears that this patch has caused suspend-to-idle regression:
>
> https://gitlab.freedesktop.org/drm/amd/-/issues/3436
>
> In brief, my laptop fails to suspend completely with the following error
> in the log:
>
> Jun 18 12:42:20 kernel: amd_pmc AMDI0005:00: Last suspend didn't reach
> deepest state
>
> Power consumption remains high enough that my battery has already
> unexpectedly drained twice before I noticed something was off.
> I am not entirely sure how changes to sorting function can influence
> suspend, but it is what it is. 6.9.5 as shipped by Fedora 40 exhibits
> the issue, 6.9.5 as shipped by Fedora with the patch reverted does not.

Andrew, could you maybe help out here or point us in the direction of
somewhat that might be able to help? I'm asking, as from a quick search
on lore it seems Kuan-Wei Chiu has not posted anything since nearly four
weeks and thus also did not reply to Julian's regression report.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.

#regzbot poke