From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
James Clark <james.clark@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Subject: [PATCH v2 0/2] perf test: Display remaining tests while waiting
Date: Sun, 30 Jun 2024 21:42:34 -0700 [thread overview]
Message-ID: <20240701044236.475098-1-irogers@google.com> (raw)
The v1 patch series:
https://lore.kernel.org/lkml/20240405070931.1231245-1-irogers@google.com/
was partially merged. The check_if_command_finished wasn't working as
intended as stdout/stderr could be lost due to waitpid being
called. Modify this function to not use waitpid and use procfs
instead.
Keeping the output test display logic in 1 place should simplify
improving parallel and sequential output. Namhyung was experiencing
issues with this in:
https://lore.kernel.org/lkml/20240628215751.1512250-1-namhyung@kernel.org/
Ian Rogers (2):
tools subcmd: Add non-waitpid check_if_command_finished()
perf test: Display number of remaining tests
tools/lib/subcmd/run-command.c | 33 ++++++++++++++
tools/perf/tests/builtin-test.c | 77 ++++++++++++++++++++++-----------
tools/perf/util/color.h | 1 +
3 files changed, 86 insertions(+), 25 deletions(-)
--
2.45.2.803.g4e1b14247a-goog
next reply other threads:[~2024-07-01 4:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 4:42 Ian Rogers [this message]
2024-07-01 4:42 ` [PATCH v2 1/2] tools subcmd: Add non-waitpid check_if_command_finished() Ian Rogers
2024-07-03 3:23 ` Namhyung Kim
2024-07-03 4:24 ` Ian Rogers
2024-07-12 20:33 ` Namhyung Kim
2024-07-12 21:19 ` Ian Rogers
2024-07-13 14:59 ` Namhyung Kim
2024-07-14 18:13 ` Ian Rogers
2024-07-01 4:42 ` [PATCH v2 2/2] perf test: Display number of remaining tests Ian Rogers
2024-07-03 3:39 ` Namhyung Kim
2024-07-03 4:30 ` Ian Rogers
2024-07-03 21:23 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701044236.475098-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox