* [PATCH] HID: mcp2221: Remove unneeded semicolon
@ 2024-07-01 7:16 Chen Ni
2024-07-01 9:12 ` Jonathan Cameron
2024-07-03 21:46 ` Andi Shyti
0 siblings, 2 replies; 4+ messages in thread
From: Chen Ni @ 2024-07-01 7:16 UTC (permalink / raw)
To: gupt21, jikos, bentiss, Jonathan.Cameron, matt
Cc: linux-i2c, linux-input, linux-kernel, Chen Ni
Remove unneeded semicolon.
This is detected by coccinelle.
Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/hid/hid-mcp2221.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
index da5ea5a23b08..0f93c22a479f 100644
--- a/drivers/hid/hid-mcp2221.c
+++ b/drivers/hid/hid-mcp2221.c
@@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
break;
default:
continue;
- };
+ }
chan->type = IIO_VOLTAGE;
chan->indexed = 1;
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] HID: mcp2221: Remove unneeded semicolon
2024-07-01 7:16 [PATCH] HID: mcp2221: Remove unneeded semicolon Chen Ni
@ 2024-07-01 9:12 ` Jonathan Cameron
2024-07-03 21:46 ` Andi Shyti
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2024-07-01 9:12 UTC (permalink / raw)
To: Chen Ni; +Cc: gupt21, jikos, bentiss, matt, linux-i2c, linux-input,
linux-kernel
On Mon, 1 Jul 2024 15:16:39 +0800
Chen Ni <nichen@iscas.ac.cn> wrote:
> Remove unneeded semicolon.
> This is detected by coccinelle.
>
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
Fixes tag not appropriate for this one as it's not a bug.
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Otherwise looks fine to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/hid/hid-mcp2221.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index da5ea5a23b08..0f93c22a479f 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
> break;
> default:
> continue;
> - };
> + }
>
> chan->type = IIO_VOLTAGE;
> chan->indexed = 1;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] HID: mcp2221: Remove unneeded semicolon
2024-07-01 7:16 [PATCH] HID: mcp2221: Remove unneeded semicolon Chen Ni
2024-07-01 9:12 ` Jonathan Cameron
@ 2024-07-03 21:46 ` Andi Shyti
1 sibling, 0 replies; 4+ messages in thread
From: Andi Shyti @ 2024-07-03 21:46 UTC (permalink / raw)
To: Chen Ni
Cc: gupt21, jikos, bentiss, Jonathan.Cameron, matt, linux-i2c,
linux-input, linux-kernel
On Mon, Jul 01, 2024 at 03:16:39PM GMT, Chen Ni wrote:
> Remove unneeded semicolon.
Please be a bit more precise: "Remove unnecessary semicolon at
the end of the switch statement"
> This is detected by coccinelle.
>
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
No need for the Fixes tag here.
Andi
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/hid/hid-mcp2221.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index da5ea5a23b08..0f93c22a479f 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
> break;
> default:
> continue;
> - };
> + }
>
> chan->type = IIO_VOLTAGE;
> chan->indexed = 1;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] HID: mcp2221: Remove unneeded semicolon
@ 2023-06-27 8:34 baomingtong001
0 siblings, 0 replies; 4+ messages in thread
From: baomingtong001 @ 2023-06-27 8:34 UTC (permalink / raw)
To: gupt21, jikos, benjamin.tissoires; +Cc: linux-i2c, linux-input, linux-kernel
./drivers/hid/hid-mcp2221.c:1027:3-4: Unneeded semicolon
Signed-off-by: Mingtong Bao <baomingtong001@208suo.com>
---
drivers/hid/hid-mcp2221.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
index 72883e0ce757..38e795c58764 100644
--- a/drivers/hid/hid-mcp2221.c
+++ b/drivers/hid/hid-mcp2221.c
@@ -1024,7 +1024,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
break;
default:
continue;
- };
+ }
chan->type = IIO_VOLTAGE;
chan->indexed = 1;
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-08 15:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 7:16 [PATCH] HID: mcp2221: Remove unneeded semicolon Chen Ni
2024-07-01 9:12 ` Jonathan Cameron
2024-07-03 21:46 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2023-06-27 8:34 baomingtong001
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox