RE: [EXTERNAL] Re: [net-next PATCH v7 06/10] octeontx2-pf: Get VF stats via representor

Geethasowjanya Akula
2024-07-04T09:39:30Z

>-----Original Message-----
>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Thursday, July 4, 2024 12:03 AM
>To: Geethasowjanya Akula <gakula@marvell.com>
>Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
>davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
>Kovvuri Goutham <sgoutham@marvell.com>; Subbaraya Sundeep Bhatta
><sbhatta@marvell.com>; Hariprasad Kelam <hkelam@marvell.com>
>Subject: Re: [EXTERNAL] Re: [net-next PATCH v7 06/10] octeontx2-pf: Get VF
>stats via representor
>
>On Wed, 3 Jul 2024 09: 08: 13 +0000 Geethasowjanya Akula wrote: >> Could
>you implement IFLA_OFFLOAD_XSTATS_CPU_HIT as well, to indicate >> how
>much of the traffic wasn't offloaded? > > Will implement while adding TC hw
>offload
>On Wed, 3 Jul 2024 09:08:13 +0000 Geethasowjanya Akula wrote:
>>> Could you implement IFLA_OFFLOAD_XSTATS_CPU_HIT as well, to indicate
>>> how much of the traffic wasn't offloaded?
>>
>> Will implement while adding TC hw offload support for the representor,
>> which will be submitted as different patch series.
>
>I don't see why we need to wait. Offload is the opposite of the stats we're
>talking about here.

Ok, will implement in next version.