From: Peter Zijlstra <peterz@infradead.org>
To: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Cc: mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, kees@kernel.org,
gustavoars@kernel.org, rui.zhang@intel.com,
oleksandr@natalenko.name, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
ananth.narayan@amd.com, gautham.shenoy@amd.com,
kprateek.nayak@amd.com, ravi.bangoria@amd.com,
sandipan.das@amd.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg*
Date: Mon, 1 Jul 2024 15:08:45 +0200 [thread overview]
Message-ID: <20240701130845.GI20127@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240624055907.7720-9-Dhananjay.Ugwekar@amd.com>
On Mon, Jun 24, 2024 at 05:59:05AM +0000, Dhananjay Ugwekar wrote:
> Prep for addition of power_per_core PMU to handle core scope energy
> consumption for AMD CPUs.
>
> Replace the generic names with *_pkg*, to differentiate between the
> scopes of the two different PMUs and their variables.
But then remember patch 2 and recall that intel seems to have everything
at die level, not pkg.
Does this proposed naming make sense? How?
next prev parent reply other threads:[~2024-07-01 13:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 5:58 [PATCH v3 00/10] Add per-core RAPL energy counter support for AMD CPUs Dhananjay Ugwekar
2024-06-24 5:58 ` [PATCH v3 01/10] x86/topology: Introduce topology_logical_core_id() Dhananjay Ugwekar
2024-06-26 14:14 ` Zhang, Rui
2024-06-24 5:58 ` [PATCH v3 02/10] perf/x86/rapl: Fix the energy-pkg event for AMD CPUs Dhananjay Ugwekar
2024-06-26 14:18 ` Zhang, Rui
2024-06-26 15:34 ` Dhananjay Ugwekar
2024-07-01 12:59 ` Peter Zijlstra
2024-07-02 9:39 ` Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 03/10] perf/x86/rapl: Rename rapl_pmu variables Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 04/10] perf/x86/rapl: Make rapl_model struct global Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 05/10] perf/x86/rapl: Move cpumask variable to rapl_pmus struct Dhananjay Ugwekar
2024-07-01 13:02 ` Peter Zijlstra
2024-07-02 10:16 ` Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 06/10] perf/x86/rapl: Add wrapper for online/offline functions Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 07/10] perf/x86/rapl: Add an argument to the cleanup and init functions Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 08/10] perf/x86/rapl: Modify the generic variable names to *_pkg* Dhananjay Ugwekar
2024-07-01 13:08 ` Peter Zijlstra [this message]
2024-07-02 2:25 ` Zhang, Rui
2024-07-02 10:20 ` Dhananjay Ugwekar
2024-07-03 4:07 ` Zhang, Rui
2024-07-03 6:31 ` Dhananjay Ugwekar
2024-07-05 2:18 ` Zhang, Rui
2024-07-05 9:24 ` Peter Zijlstra
2024-07-08 1:56 ` Zhang, Rui
2024-06-24 5:59 ` [PATCH v3 09/10] perf/x86/rapl: Remove the global variable rapl_msrs Dhananjay Ugwekar
2024-06-24 5:59 ` [PATCH v3 10/10] perf/x86/rapl: Add per-core energy counter support for AMD CPUs Dhananjay Ugwekar
2024-06-26 15:18 ` Zhang, Rui
2024-06-26 16:37 ` Dhananjay Ugwekar
2024-06-27 6:49 ` Zhang, Rui
2024-06-27 11:13 ` Dhananjay Ugwekar
2024-06-24 6:39 ` [PATCH v3 00/10] Add per-core RAPL " K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701130845.GI20127@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Dhananjay.Ugwekar@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ananth.narayan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=gustavoars@kernel.org \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=kees@kernel.org \
--cc=kprateek.nayak@amd.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=oleksandr@natalenko.name \
--cc=ravi.bangoria@amd.com \
--cc=rui.zhang@intel.com \
--cc=sandipan.das@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox