Re: [PATCH v3 2/3] iommu/arm-smmu-qcom-debug: Do not print for handled faults

Pranjal Shrivastava
2024-07-01T19:34:06Z

On Mon, Jul 1, 2024 at 9:50 PM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> Handled faults can be "normal", don't spam dmesg about them.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c
> index e4ee78fb6a66..681fbdfc325d 100644
> --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c
> +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c
> @@ -419,10 +419,6 @@ irqreturn_t qcom_smmu_context_fault(int irq, void *dev)
> tmp = report_iommu_fault(&smmu_domain->domain, NULL, iova,
> fsynr & ARM_SMMU_CB_FSYNR0_WNR ? IOMMU_FAULT_WRITE : IOMMU_FAULT_READ);
> if (!tmp || tmp == -EBUSY) {
> - dev_dbg(smmu->dev,
> - "Context fault handled by client: iova=0x%08lx, fsr=0x%x, fsynr=0x%x, cb=%d\n",
> - iova, fsr, fsynr, idx);
> - dev_dbg(smmu->dev, "soft iova-to-phys=%pa\n", &phys_soft);
> ret = IRQ_HANDLED;
> resume = ARM_SMMU_RESUME_TERMINATE;
> } else {
> --
> 2.45.2
>
Seems consistent with the arm_smmu_context_fault handler.
Reviewed-by: Pranjal Shrivastava <praan@google.com>