Re: [PATCH 05/13] rust: simplify Clippy warning flags set

Finn Behrens
2024-07-04T14:37:55Z

On 1 Jul 2024, at 20:36, Miguel Ojeda wrote:

> All Clippy lint groups that we enable, except `correctness`, have a
> default `warn` level, thus they may be removed now that we relaxed all
> lints to `warn`.
>
> Moreover, Clippy provides an `all` lint group that covers the groups
> we enable by default. Thus just use `all` instead -- the only change is
> that, if Clippy introduces a new lint group or splits an existing one,
> we will cover that one automatically.
>
> In addition, `let_unit_value` is in `style` since Rust 1.62.0, thus it
> does not need to be enabled manually.
>
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

Reviewed-by: Finn Behrens <me@kloenk.dev>

> ---
> Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 056176a55d63..3f43f03f855e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -465,10 +465,8 @@ export rust_common_flags := --edition=2021 \
> -Wunreachable_pub -Wnon_ascii_idents \
> -Wmissing_docs \
> -Wrustdoc::missing_crate_level_docs \
> - -Wclippy::correctness -Wclippy::style \
> - -Wclippy::suspicious -Wclippy::complexity \
> - -Wclippy::perf \
> - -Wclippy::let_unit_value -Wclippy::mut_mut \
> + -Wclippy::all \
> + -Wclippy::mut_mut \
> -Wclippy::needless_bitwise_bool \
> -Wclippy::needless_continue \
> -Wclippy::no_mangle_with_rust_abi \
> --
> 2.45.2