From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19D0D16CD15; Mon, 1 Jul 2024 19:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719863345; cv=none; b=Qj8jShG12RYyg6kmizj5GYZf40VCAX3SkZtoVsUUQbfMdWd/BvLjJJitJS5c2ZnrHM+MdsYYhmpRyazm1Q/6dZd2+DV56YvH4SfUgqfj63n/TUyFAQVhSA8Ch1uqHYzrKi48DYkSuD4MHW2wAT8HSfsIVczCRcR4vWwhXiLhb8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719863345; c=relaxed/simple; bh=zQLlNeL1vEPNYFTUeDSkHfau4N62hdB+0K+910LcGDQ=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=lS63IAvceLfxb+6sKRvU19uWvrDwf1hlG3iUZudYL0vdFYcvpCCREiFP09Xdlz7SbT5b/1ZZLtZWmRIf+OuDLyrD87RKmwac3qmccdo0+gWmu3odvxO/JRMRIEdHR02hCn6VPi+d4Y8Mx528La0wNcDStFqdeOz/cIYpFxWJa4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=izRjTP7f; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="izRjTP7f" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3894AC32786; Mon, 1 Jul 2024 19:49:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719863344; bh=zQLlNeL1vEPNYFTUeDSkHfau4N62hdB+0K+910LcGDQ=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=izRjTP7fn/CmHJ8zsepzQCFxuspZHpEY4VgfgjR53mrr5p9EY3+7ZTr7GLzd/cGYl 9VX0nxhj/ukhlI9kVaENGku38ir6u57ZepHtP6ULabOv74DjOgqEwrunVluJwd2onf 0y1xbLaXMEoYrdfRPP+60R/uiRgpWINoYZsRk1hxd+QcK/Oi+gUnhNilUC1P/PuoSd 6MuBcKlQOF2xg6AsKEZY/omYk/fKKM+vhvxJV3OA82OQSahRsqEr77CqshDbrbqx+g cyWApNcp+SBy2Yuspcct1eEy7XFvW4Z+ca2KLWMzcshKpGcHbY4Udb2c1Gv2qfa+3t fhqsetWXDtS+Q== Date: Mon, 1 Jul 2024 14:49:02 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com, Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v1 2/8] PCI: brcmstb: Use "clk_out" error path label Message-ID: <20240701194902.GA14422@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628205430.24775-3-james.quinlan@broadcom.com> On Fri, Jun 28, 2024 at 04:54:21PM -0400, Jim Quinlan wrote: > Instead of invoking "clk_disable_unprepare(pcie->clk)" in > a number of error paths. It's nice if the commit log is readable by itself, without reading the subject line as the first line of the commit log. Same way a title is not directly part of an article/essay/book itself.