From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the pci tree
Date: Tue, 2 Jul 2024 05:18:33 +0900 [thread overview]
Message-ID: <20240701201833.GB272504@rocinante> (raw)
In-Reply-To: <ZoJg_k2En6bqQzA4@ryzen.lan>
Hello,
> > In commit
> >
> > aaf840725904 ("PCI: dw-rockchip: Depend on PCI_ENDPOINT if building endpoint mode support")
> >
> > Fixes tag
> >
> > Fixes: 9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support")
> >
> > has these problem(s):
> >
> > - Target SHA1 does not exist
> >
> > Maybe you meant
> >
> > Fixes: 728538f5e806 ("PCI: dw-rockchip: Add endpoint mode support")
[...]
> The branch was rebased so the SHA1 changed.
>
> Perhaps the maintainers could update the Fixes tag.
>
> (Personally, I would just squash the small fix with the commit that it fixes.)
I will squash the patch that adds PCI_ENDPOINT dependency with the rest of
the series, and then drop the Fixes: tag afterwards, since it would not
longer be needed.
Krzysztof
next prev parent reply other threads:[~2024-07-01 20:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 23:13 linux-next: Fixes tag needs some work in the pci tree Stephen Rothwell
2024-07-01 7:55 ` Niklas Cassel
2024-07-01 20:18 ` Krzysztof Wilczyński [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-24 21:08 Stephen Rothwell
2024-10-24 21:10 ` Stephen Rothwell
2024-10-24 21:21 ` Mario Limonciello
2023-01-15 21:14 Stephen Rothwell
2023-01-16 3:23 ` Alexey V. Vissarionov
2023-01-18 17:06 ` Bjorn Helgaas
2020-11-22 9:55 Stephen Rothwell
2020-11-22 15:13 ` Bjorn Helgaas
2020-07-22 0:33 Stephen Rothwell
2020-03-30 20:38 Stephen Rothwell
2020-03-30 20:53 ` Bjorn Helgaas
2020-03-31 3:14 ` Lukas Wunner
2020-03-31 3:32 ` Lukas Wunner
2020-03-31 15:32 ` Bjorn Helgaas
2019-06-22 13:40 Stephen Rothwell
2019-06-26 10:00 ` Lorenzo Pieralisi
2019-06-26 14:51 ` Bharat Kumar Gogada
2019-02-12 23:03 Stephen Rothwell
2019-02-13 9:55 ` Lorenzo Pieralisi
2019-02-13 14:31 ` Bjorn Helgaas
2019-02-13 20:09 ` Stephen Rothwell
2019-02-13 20:19 ` Bjorn Helgaas
2019-02-13 21:17 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701201833.GB272504@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox