public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: linux-hwmon@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Farouk Bouabid <farouk.bouabid@cherry.de>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 08/11] hwmon: (amc6821) Drop unnecessary enum chips
Date: Mon,  1 Jul 2024 14:23:45 -0700	[thread overview]
Message-ID: <20240701212348.1670617-9-linux@roeck-us.net> (raw)
In-Reply-To: <20240701212348.1670617-1-linux@roeck-us.net>

The driver only supports a single chip, so an enum
to determine the chip type is unnecessary. Drop it.

No functional change intended.

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Add Quentin's Reviewed-by: tag

 drivers/hwmon/amc6821.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index fa9f64c743ff..028998d3bedf 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -36,8 +36,6 @@ module_param(pwminv, int, 0444);
 static int init = 1; /*Power-on initialization.*/
 module_param(init, int, 0444);
 
-enum chips { amc6821 };
-
 #define AMC6821_REG_DEV_ID		0x3D
 #define AMC6821_REG_COMP_ID		0x3E
 #define AMC6821_REG_CONF1		0x00
@@ -945,7 +943,7 @@ static int amc6821_probe(struct i2c_client *client)
 }
 
 static const struct i2c_device_id amc6821_id[] = {
-	{ "amc6821", amc6821 },
+	{ "amc6821", 0 },
 	{ }
 };
 
@@ -954,7 +952,6 @@ MODULE_DEVICE_TABLE(i2c, amc6821_id);
 static const struct of_device_id __maybe_unused amc6821_of_match[] = {
 	{
 		.compatible = "ti,amc6821",
-		.data = (void *)amc6821,
 	},
 	{ }
 };
-- 
2.39.2


  parent reply	other threads:[~2024-07-01 21:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 21:23 [PATCH v2 00/11] hwmon: (amc6821) Various improvements Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 01/11] hwmon: (amc6821) Stop accepting invalid pwm values Guenter Roeck
2024-07-03 14:29   ` Quentin Schulz
2024-07-03 20:17     ` Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 02/11] hwmon: (amc6821) Make reading and writing fan speed limits consistent Guenter Roeck
2024-07-03 14:35   ` Quentin Schulz
2024-07-03 21:48     ` Guenter Roeck
2024-07-04  7:52       ` Quentin Schulz
2024-07-04 17:50         ` Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 03/11] hwmon: (amc6821) Rename fan1_div to fan1_pulses Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 04/11] hwmon: (amc6821) Add support for fan1_target and pwm1_enable mode 4 Guenter Roeck
2024-07-03 14:43   ` Quentin Schulz
2024-07-01 21:23 ` [PATCH v2 05/11] hwmon: (amc2821) Reorder include files, drop unnecessary ones Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 06/11] hwmon: (amc6821) Use tabs for column alignment in defines Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 07/11] hwmon: (amc2821) Use BIT() and GENMASK() Guenter Roeck
2024-07-03 14:45   ` Quentin Schulz
2024-07-01 21:23 ` Guenter Roeck [this message]
2024-07-01 21:23 ` [PATCH v2 09/11] hwmon: (amc6821) Convert to use regmap Guenter Roeck
2024-07-03 16:19   ` Quentin Schulz
2024-07-03 20:55     ` Guenter Roeck
2024-07-01 21:23 ` [PATCH v2 10/11] hwmon: (amc6821) Convert to with_info API Guenter Roeck
2024-07-03 15:34   ` Quentin Schulz
2024-07-01 21:23 ` [PATCH v2 11/11] hwmon: (amc6821) Add support for pwm1_mode attribute Guenter Roeck
2024-07-03 15:28   ` Quentin Schulz
2024-07-03 21:29     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701212348.1670617-9-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=farouk.bouabid@cherry.de \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quentin.schulz@cherry.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox