Re: [RFC PATCH 2/9] PCI/AER: Call AER CE handler before clearing AER CE status register

Terry Bowman
2024-06-24T18:00:52Z

Hi Dan, I added a response below.

On 6/21/24 14:23, Dan Williams wrote:
> Terry Bowman wrote:
>> The AER service driver clears the AER correctable error (CE) status before
>> calling the correctable error handler. This results in the error's status
>> not correctly reflected if read from the CE handler.
>>
>> The AER CE status is needed by the portdrv's CE handler. The portdrv's
>> CE handler is intended to only call the registered notifier callbacks
>> if the CE error status has correctable internal error (CIE) set.
>
> Is this a fix or a prep patch? It reads like a "fix", but there are no
> notifiers to worry about today.
>

I will add mention "in preparation for future patch".

>> This is not a problem for AER uncorrrectbale errors (UCE). The UCE status
>> is still present in the AER capability and available for reading, if
>> needed, when the UCE handler is called.
>>
>> Change the order of clearing the CE status and calling the CE handler.
>> Make it to call the CE handler first and then clear the CE status
>> after returning.
>
> With the changelog clarified to indicate whether this has any impact on
> current behavior you can add:
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>

Regards,
Terry