From: Masahiro Yamada <masahiroy@kernel.org>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas@fjasle.eu>
Subject: [PATCH v2 1/3] kbuild: deb-pkg: remove support for EMAIL environment variable
Date: Wed, 3 Jul 2024 03:02:40 +0900 [thread overview]
Message-ID: <20240702180332.398978-1-masahiroy@kernel.org> (raw)
Commit edec611db047 ("kbuild, deb-pkg: improve maintainer
identification") added the EMAIL and NAME environment variables.
Commit d5940c60e057 ("kbuild: deb-pkg improve maintainer address
generation") removed support for NAME, but kept support for EMAIL.
The EMAIL and NAME environment variables are still supported by some
tools (see 'man debchange'), but not by all.
We should support both of them, or neither of them. We should not stop
halfway.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
Changes in v2:
- New patch
scripts/package/mkdebian | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
index b9a5b789c655..589f92b88c42 100755
--- a/scripts/package/mkdebian
+++ b/scripts/package/mkdebian
@@ -125,7 +125,7 @@ gen_source ()
rm -rf debian
mkdir debian
-email=${DEBEMAIL-$EMAIL}
+email=${DEBEMAIL}
# use email string directly if it contains <email>
if echo "${email}" | grep -q '<.*>'; then
--
2.43.0
next reply other threads:[~2024-07-02 18:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 18:02 Masahiro Yamada [this message]
2024-07-02 18:02 ` [PATCH v2 2/3] kbuild: deb-pkg: remove support for "name <email>" form for DEBEMAIL Masahiro Yamada
2024-07-03 15:06 ` Masahiro Yamada
2024-07-04 9:28 ` Nicolas Schier
2024-07-02 18:02 ` [PATCH v2 3/3] kbuild: package: add -e and -u options to some shell scripts Masahiro Yamada
2024-07-03 14:57 ` [PATCH v2 1/3] kbuild: deb-pkg: remove support for EMAIL environment variable Masahiro Yamada
2024-07-04 9:26 ` Nicolas Schier
2024-07-03 16:33 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702180332.398978-1-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox