Re: [PATCH v2 1/3] kbuild: deb-pkg: remove support for EMAIL environment variable

Nicolas Schier
2024-07-04T09:26:51Z

On Wed, Jul 03, 2024 at 11:57:44PM +0900, Masahiro Yamada wrote:
> (+CC more Debian developers)
>
>
> On Wed, Jul 3, 2024 at 3:03 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Commit edec611db047 ("kbuild, deb-pkg: improve maintainer
> > identification") added the EMAIL and NAME environment variables.
> >
> > Commit d5940c60e057 ("kbuild: deb-pkg improve maintainer address
> > generation") removed support for NAME, but kept support for EMAIL.
> >
> > The EMAIL and NAME environment variables are still supported by some
> > tools (see 'man debchange'), but not by all.
> >
> > We should support both of them, or neither of them. We should not stop
> > halfway.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> > Changes in v2:
> > - New patch
> >
> > scripts/package/mkdebian | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/package/mkdebian b/scripts/package/mkdebian
> > index b9a5b789c655..589f92b88c42 100755
> > --- a/scripts/package/mkdebian
> > +++ b/scripts/package/mkdebian
> > @@ -125,7 +125,7 @@ gen_source ()
> > rm -rf debian
> > mkdir debian
> >
> > -email=${DEBEMAIL-$EMAIL}
> > +email=${DEBEMAIL}
> >
> > # use email string directly if it contains <email>
> > if echo "${email}" | grep -q '<.*>'; then
> > --
> > 2.43.0

Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>