From: Jim Cromie <jim.cromie@gmail.com>
To: daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com,
jani.nikula@intel.com, ville.syrjala@linux.intel.com,
jbaron@akamai.com, gregkh@linuxfoundation.org,
ukaszb@chromium.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux@rasmusvillemoes.dk,
joe@perches.com, mcgrof@kernel.org,
Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v9 07/52] dyndbg: split param_set_dyndbg_classes to _module & wrapper fns
Date: Tue, 2 Jul 2024 15:56:57 -0600 [thread overview]
Message-ID: <20240702215804.2201271-8-jim.cromie@gmail.com> (raw)
In-Reply-To: <20240702215804.2201271-1-jim.cromie@gmail.com>
Split api-fn: param_set_dyndbg_classes(), adding modname param and
passing NULL in from api-fn.
The new arg allows caller to specify that only one module is affected
by a prdbgs update. This selectivity will be used later to narrow the
scope of changes made.
no functional change.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
lib/dynamic_debug.c | 37 ++++++++++++++++++++++---------------
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index a1fd2e9dbafb..4a48f830507f 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -711,18 +711,9 @@ static int param_set_dyndbg_classnames(const char *instr, const struct kernel_pa
return 0;
}
-/**
- * param_set_dyndbg_classes - class FOO >control
- * @instr: string echo>d to sysfs, input depends on map_type
- * @kp: kp->arg has state: bits/lvl, map, map_type
- *
- * Enable/disable prdbgs by their class, as given in the arguments to
- * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative
- * levels by bitpos.
- *
- * Returns: 0 or <0 if error.
- */
-int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
+static int param_set_dyndbg_module_classes(const char *instr,
+ const struct kernel_param *kp,
+ const char *modnm)
{
const struct ddebug_class_param *dcp = kp->arg;
const struct ddebug_class_map *map = dcp->map;
@@ -759,8 +750,8 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
KP_NAME(kp), inrep, CLASSMAP_BITMASK(map->length));
inrep &= CLASSMAP_BITMASK(map->length);
}
- v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp));
- totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, NULL);
+ v2pr_info("bits:0x%lx > %s.%s\n", inrep, modnm ?: "*", KP_NAME(kp));
+ totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, modnm);
*dcp->bits = inrep;
break;
case DD_CLASS_TYPE_LEVEL_NUM:
@@ -773,7 +764,7 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
old_bits = CLASSMAP_BITMASK(*dcp->lvl);
new_bits = CLASSMAP_BITMASK(inrep);
v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp));
- totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, NULL);
+ totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, modnm);
*dcp->lvl = inrep;
break;
default:
@@ -782,6 +773,22 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
vpr_info("%s: total matches: %d\n", KP_NAME(kp), totct);
return 0;
}
+
+/**
+ * param_set_dyndbg_classes - class FOO >control
+ * @instr: string echo>d to sysfs, input depends on map_type
+ * @kp: kp->arg has state: bits/lvl, map, map_type
+ *
+ * Enable/disable prdbgs by their class, as given in the arguments to
+ * DECLARE_DYNDBG_CLASSMAP. For LEVEL map-types, enforce relative
+ * levels by bitpos.
+ *
+ * Returns: 0 or <0 if error.
+ */
+int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp)
+{
+ return param_set_dyndbg_module_classes(instr, kp, NULL);
+}
EXPORT_SYMBOL(param_set_dyndbg_classes);
/**
--
2.45.2
next prev parent reply other threads:[~2024-07-02 21:58 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 21:56 [PATCH v9 00/53] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y Jim Cromie
2024-07-02 21:56 ` [PATCH v9 01/52] docs/dyndbg: update examples \012 to \n Jim Cromie
2024-07-02 21:56 ` [PATCH v9 02/52] test-dyndbg: fixup CLASSMAP usage error Jim Cromie
2024-07-02 21:56 ` [PATCH v9 03/52] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2024-07-02 21:56 ` [PATCH v9 04/52] dyndbg: make ddebug_class_param union members same size Jim Cromie
2024-07-02 21:56 ` [PATCH v9 05/52] dyndbg: replace classmap list with a vector Jim Cromie
2024-07-02 21:56 ` [PATCH v9 06/52] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Jim Cromie
2024-07-02 21:56 ` Jim Cromie [this message]
2024-07-02 21:56 ` [PATCH v9 08/52] dyndbg: drop NUM_TYPE_ARRAY Jim Cromie
2024-07-02 21:56 ` [PATCH v9 09/52] dyndbg: reduce verbose/debug clutter Jim Cromie
2024-07-02 21:57 ` [PATCH v9 10/52] dyndbg: silence debugs with no-change updates Jim Cromie
2024-07-02 21:57 ` [PATCH v9 11/52] dyndbg: tighten ddebug_class_name() 1st arg type Jim Cromie
2024-07-02 21:57 ` [PATCH v9 12/52] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2024-07-02 21:57 ` [PATCH v9 13/52] dyndbg: reduce verbose=3 messages in ddebug_add_module Jim Cromie
2024-07-02 21:57 ` [PATCH v9 14/52] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2024-07-02 21:57 ` [PATCH v9 15/52] dyndbg-API: fix DECLARE_DYNDBG_CLASSMAP Jim Cromie
2024-07-02 21:57 ` [PATCH v9 16/52] selftests-dyndbg: add tools/testing/selftests/dynamic_debug/* Jim Cromie
2024-07-02 21:57 ` [PATCH v9 17/52] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API Jim Cromie
2024-07-02 21:57 ` [PATCH v9 18/52] dyndbg-doc: add classmap info to howto Jim Cromie
2024-07-02 21:57 ` [PATCH v9 19/52] dyndbg: treat comma as a token separator Jim Cromie
2024-07-02 21:57 ` [PATCH v9 20/52] selftests-dyndbg: add comma_terminator_tests Jim Cromie
2024-07-02 21:57 ` [PATCH v9 21/52] dyndbg: split multi-query strings with % Jim Cromie
2024-07-02 21:57 ` [PATCH v9 22/52] selftests-dyndbg: test_percent_splitting Jim Cromie
2024-07-02 21:57 ` [PATCH v9 23/52] docs/dyndbg: explain new delimiters: comma, percent Jim Cromie
2024-07-02 21:57 ` [PATCH v9 24/52] selftests-dyndbg: add test_mod_submod Jim Cromie
2024-07-02 21:57 ` [PATCH v9 25/52] dyndbg-doc: explain flags parse 1st Jim Cromie
2024-07-02 21:57 ` [PATCH v9 26/52] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2024-07-02 21:57 ` [PATCH v9 27/52] selftests-dyndbg: check KCONFIG_CONFIG to avoid silly fails Jim Cromie
2024-07-10 20:22 ` Helen Koike
2024-07-14 16:13 ` jim.cromie
2024-07-02 21:57 ` [PATCH v9 28/52] dyndbg-selftest: reduce default verbosity Jim Cromie
2024-07-02 21:57 ` [PATCH v9 29/52] drm: use correct ccflags-y spelling Jim Cromie
2024-07-02 21:57 ` [PATCH v9 30/52] drm-dyndbg: adapt drm core to use dyndbg classmaps-v2 Jim Cromie
2024-07-02 23:33 ` Ville Syrjälä
2024-07-03 2:34 ` jim.cromie
2024-07-03 11:52 ` Ville Syrjälä
2024-07-03 16:11 ` jim.cromie
2024-07-10 0:25 ` jim.cromie
2024-07-02 21:57 ` [PATCH v9 31/52] drm-dyndbg: adapt DRM to invoke DYNDBG_CLASSMAP_PARAM Jim Cromie
2024-07-02 21:57 ` [PATCH v9 32/53] DRM-CLASSMAP-USE in drm-drv.c Jim Cromie
2024-07-02 22:21 ` jim.cromie
2024-07-02 21:57 ` [PATCH v9 32/52] drm-dyndbg: DRM_CLASSMAP_USE in amdgpu driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 33/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 33/52] drm-dyndbg: DRM_CLASSMAP_USE in i915 driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 34/52] drm-dyndbg: DRM_CLASSMAP_USE in drm_crtc_helper Jim Cromie
2024-07-02 21:57 ` [PATCH v9 34/53] drm-dyndbg: DRM_CLASSMAP_USE in i915 driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 35/53] drm-dyndbg: DRM_CLASSMAP_USE in drm_crtc_helper Jim Cromie
2024-07-02 21:57 ` [PATCH v9 35/52] drm-dyndbg: DRM_CLASSMAP_USE in drm_dp_helper Jim Cromie
2024-07-02 21:57 ` [PATCH v9 36/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 36/52] drm-dyndbg: DRM_CLASSMAP_USE in nouveau Jim Cromie
2024-07-02 21:57 ` [PATCH v9 37/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 37/52] drm-print: workaround unused variable compiler meh Jim Cromie
2024-07-02 21:57 ` [PATCH v9 38/52] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 38/53] drm-print: workaround unused variable compiler meh Jim Cromie
2024-07-02 21:57 ` [PATCH v9 39/52] drm-dyndbg: add DRM_CLASSMAP_USE to virtio_gpu Jim Cromie
2024-07-02 21:57 ` [PATCH v9 39/53] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 40/52] drm-dyndbg: add DRM_CLASSMAP_USE to simpledrm Jim Cromie
2024-07-02 21:57 ` [PATCH v9 40/53] drm-dyndbg: add DRM_CLASSMAP_USE to virtio_gpu Jim Cromie
2024-07-02 21:57 ` [PATCH v9 41/52] drm-dyndbg: add DRM_CLASSMAP_USE to bochs Jim Cromie
2024-07-02 21:57 ` [PATCH v9 41/53] drm-dyndbg: add DRM_CLASSMAP_USE to simpledrm Jim Cromie
2024-07-02 21:57 ` [PATCH v9 42/53] drm-dyndbg: add DRM_CLASSMAP_USE to bochs Jim Cromie
2024-07-02 21:57 ` [PATCH v9 42/52] drm-dyndbg: add DRM_CLASSMAP_USE to etnaviv Jim Cromie
2024-07-02 21:57 ` [PATCH v9 43/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 43/52] drm-dyndbg: add DRM_CLASSMAP_USE to gma500 driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 44/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 44/52] drm-dyndbg: add DRM_CLASSMAP_USE to radeon Jim Cromie
2024-07-02 21:57 ` [PATCH v9 45/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 45/52] drm-dyndbg: add DRM_CLASSMAP_USE to vmwgfx driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 46/52] drm-dyndbg: add DRM_CLASSMAP_USE to vkms driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 46/53] drm-dyndbg: add DRM_CLASSMAP_USE to vmwgfx driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 47/52] drm-dyndbg: add DRM_CLASSMAP_USE to udl driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 47/53] drm-dyndbg: add DRM_CLASSMAP_USE to vkms driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 48/52] drm-dyndbg: add DRM_CLASSMAP_USE to mgag200 driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 48/53] drm-dyndbg: add DRM_CLASSMAP_USE to udl driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 49/53] drm-dyndbg: add DRM_CLASSMAP_USE to mgag200 driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 49/52] drm-dyndbg: add DRM_CLASSMAP_USE to the gud driver Jim Cromie
2024-07-02 21:57 ` [PATCH v9 50/53] " Jim Cromie
2024-07-02 21:57 ` [PATCH v9 50/52] drm-dyndbg: add DRM_CLASSMAP_USE to the qxl driver Jim Cromie
2024-07-02 21:58 ` [PATCH v9 51/52] drm-dyndbg: add DRM_CLASSMAP_USE to the drm_gem_shmem_helper driver Jim Cromie
2024-07-02 21:58 ` [PATCH v9 51/53] drm-dyndbg: add DRM_CLASSMAP_USE to the qxl driver Jim Cromie
2024-07-02 21:58 ` [PATCH v9 52/53] drm-dyndbg: add DRM_CLASSMAP_USE to the drm_gem_shmem_helper driver Jim Cromie
2024-07-02 21:58 ` [PATCH v9 52/52] drm: restore CONFIG_DRM_USE_DYNAMIC_DEBUG un-BROKEN Jim Cromie
2024-07-02 21:58 ` [PATCH v9 53/53] " Jim Cromie
2024-07-02 22:01 ` [PATCH v9 00/53] fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y Luis Chamberlain
2024-07-02 22:14 ` jim.cromie
2024-07-12 15:44 ` Łukasz Bartosik
2024-07-13 21:44 ` jim.cromie
2024-07-15 10:04 ` Łukasz Bartosik
2024-07-15 18:00 ` jim.cromie
2024-07-17 10:38 ` Łukasz Bartosik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240702215804.2201271-8-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jbaron@akamai.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mcgrof@kernel.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=ukaszb@chromium.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox