From: Andre Przywara <andre.przywara@arm.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Bjorn Andersson <andersson@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Michal Simek <michal.simek@amd.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 09/10] clk: sunxi-ng r40: Constify struct regmap_config
Date: Wed, 3 Jul 2024 12:17:50 +0100 [thread overview]
Message-ID: <20240703121750.0dc2eb3a@donnerap.manchester.arm.com> (raw)
In-Reply-To: <20240703-clk-const-regmap-v1-9-7d15a0671d6f@gmail.com>
On Wed, 03 Jul 2024 11:50:22 +0200
Javier Carrasco <javier.carrasco.cruz@gmail.com> wrote:
> `sun8i_r40_ccu_regmap_config` is not modified and can be declared as
> const to move its data to a read-only section.
>
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Looks alright, we indeed don't change it, and the only user takes a const
pointer. Also the compiler seems happy.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> drivers/clk/sunxi-ng/ccu-sun8i-r40.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c
> index 984ad3f76b18..2f51ceab8016 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun8i-r40.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun8i-r40.c
> @@ -1292,7 +1292,7 @@ static bool sun8i_r40_ccu_regmap_accessible_reg(struct device *dev,
> return false;
> }
>
> -static struct regmap_config sun8i_r40_ccu_regmap_config = {
> +static const struct regmap_config sun8i_r40_ccu_regmap_config = {
> .reg_bits = 32,
> .val_bits = 32,
> .reg_stride = 4,
>
next prev parent reply other threads:[~2024-07-03 11:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 9:50 [PATCH 00/10] clk: constify struct regmap_config Javier Carrasco
2024-07-03 9:50 ` [PATCH 01/10] clk: meson: a1: peripherals: Constify " Javier Carrasco
2024-07-03 10:54 ` Neil Armstrong
2024-07-15 12:08 ` [DMARC error][DKIM error] " Dmitry Rokosov
2024-07-03 9:50 ` [PATCH 02/10] clk: meson: a1: pll: " Javier Carrasco
2024-07-03 10:54 ` Neil Armstrong
2024-07-15 12:10 ` [DMARC error][DKIM error] " Dmitry Rokosov
2024-07-03 9:50 ` [PATCH 03/10] clk: meson: c3: peripherals: " Javier Carrasco
2024-07-03 10:54 ` Neil Armstrong
2024-07-03 9:50 ` [PATCH 04/10] clk: meson: c3: pll: " Javier Carrasco
2024-07-03 10:54 ` Neil Armstrong
2024-07-03 9:50 ` [PATCH 05/10] clk: meson: s4: peripherals: " Javier Carrasco
2024-07-03 10:54 ` Neil Armstrong
2024-07-03 9:50 ` [PATCH 06/10] clk: meson: s4: pll: " Javier Carrasco
2024-07-03 10:54 ` Neil Armstrong
2024-07-03 9:50 ` [PATCH 07/10] clk: lpc32xx: " Javier Carrasco
2024-07-08 20:32 ` Stephen Boyd
2024-07-03 9:50 ` [PATCH 08/10] clk: qcom: lpasscc-sc8280xp: " Javier Carrasco
2024-07-03 10:50 ` Dmitry Baryshkov
2024-07-03 9:50 ` [PATCH 09/10] clk: sunxi-ng r40: " Javier Carrasco
2024-07-03 11:17 ` Andre Przywara [this message]
2024-07-10 16:53 ` Chen-Yu Tsai
2024-07-10 19:47 ` Stephen Boyd
2024-07-03 9:50 ` [PATCH 10/10] clk: xilinx: " Javier Carrasco
2024-07-08 20:32 ` Stephen Boyd
2024-07-06 22:01 ` (subset) [PATCH 00/10] clk: constify " Bjorn Andersson
2024-07-10 12:41 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240703121750.0dc2eb3a@donnerap.manchester.arm.com \
--to=andre.przywara@arm.com \
--cc=andersson@kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jernej.skrabec@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=samuel@sholland.org \
--cc=sboyd@kernel.org \
--cc=vz@mleia.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox