From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 197D817A5A8 for ; Wed, 3 Jul 2024 13:46:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720014384; cv=none; b=D4DQxF5GEG7NvAj7su9aHSnmfSYP8TpEwfmhXv6nm7R9+iUXN3OYp4+dH7ZQibqi8RFXfyxJVjtAwrfdqpwbwpNYGSQZ168nrsK3iAnpszzkOoPdhV8fOf4m5p58/zT77FaT1nLiV2al08YiLoc4OFXoGqPWWArBswGrZoZ1Nm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720014384; c=relaxed/simple; bh=/m6A+sXoU4Olg6HTeHCABBg9ut0WZrDY9nPjeBeXu2A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kkW1IayOXPlwpGaD9UkuDNCWcfzIFeUVcX2T7REuATgG+Pf1ET0PLA8U8rh/RywRzGdoEfTXxU6LMMplJUwhxwNP9UyuLOA7PT/kA//1bIWJVyCoqMCQgHJ4xOFPlM4uY57CejoNZanzA7Bfq12+STKCXNr2lRRmvIDambP85d8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HxnttMfA; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HxnttMfA" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-6eab07ae82bso3270341a12.3 for ; Wed, 03 Jul 2024 06:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720014381; x=1720619181; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Bf+gEq9Qv4j2DaejyoY0EnJO0snP/b2OWlh18sSmCtA=; b=HxnttMfAn3tuNMuEG6PxLR3uCCkn1CEHyb1QYrRd6ISEV3ezk6dr+FXFedyY4XcWn4 gOqJRhG67Xj1TtUoxaRPpGHgAkzBFBzBa5cBv8pgPyzPvJxOKNGhHTkBV3RM9cxWWiSf rH08kpUyb1gdEbw1eKWkb4nmhLiK1VGbYHoDsS0JnqN1P3sTfK2aHuXkdq+5BKWm386d 2Kx5OrWk7x8nIJLGowHsnEX6DVRFZkOAER/nfdXLsffCkuIOEmczPwHASREU8sX26Z8v K0+iKliW+ZMwe7GQTkL0DZHbC9KIo1jDxuMb/W3rrfyNi5MkauNoFd+77dnrNmiFX5xt xC2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720014381; x=1720619181; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bf+gEq9Qv4j2DaejyoY0EnJO0snP/b2OWlh18sSmCtA=; b=I5r2v319rrxtC8BKwwU2+09RABS8lH2Z0J6D5HEX8TUSrTs4MicfTLqZge8PWjw14f 7tZNrqKFx6oTgR8cdgFGPwFsJB+XLLaFklZ5tfITzImkQOxMCOb94NUUdQiXqyBuhFkb tGP5HNiBEBpWoOrpikVVEDEdpvLmECGmP6bQMrhe0L06hNLedOiJoknbHL2+2tbZ+HB+ uhxhYUsMHZy0Xb4FQ8u4bOJ69jxiBKT18uTwUx5yU4s9aZ0oh6KzSFWVVa80qY500f8/ TfQiAcrzbde9ADRZmG1+fYEZ3dpt8cDFyNmocaFIl5q5P96iKQMcTKgF17aYgm0XnxFZ ToHw== X-Forwarded-Encrypted: i=1; AJvYcCWB8llkyuAEXIYeba2/rETXs/yjZ2i95Lj1/Tlu9YGQRKRmBMtReXK7V85EImDkhvEHfbWnyEVXKSMW8cMw8AaR/H65cywKrE9+SFaz X-Gm-Message-State: AOJu0YzcaOzIyoyArDpk7hFRHsuf2rdC7UYuW8Y/n21pAKbHSqDNqq0L LAu/7vt1+SKdwHhJD7pSDruuZR3bV7x566CMgqd5EsfeOmgSfV7ChmUJzmwsBg== X-Google-Smtp-Source: AGHT+IFbgy8xFgSDq57ntgaSsYgc8vIgCPq4hdC8aq3qDRUkMazMF18pniYYlOiILpepBoDGTQuepQ== X-Received: by 2002:a05:6a20:3c94:b0:1be:c4b9:c216 with SMTP id adf61e73a8af0-1bef60f3c38mr12064525637.7.1720014381428; Wed, 03 Jul 2024 06:46:21 -0700 (PDT) Received: from thinkpad ([220.158.156.98]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c91d3e7d7bsm10761774a91.47.2024.07.03.06.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Jul 2024 06:46:20 -0700 (PDT) Date: Wed, 3 Jul 2024 19:16:16 +0530 From: Manivannan Sadhasivam To: Slark Xiao Cc: loic.poulain@linaro.org, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, quic_jhugo@quicinc.com, netdev@vger.kernel.org, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] bus: mhi: host: Add name for mhi_controller Message-ID: <20240703134616.GC4342@thinkpad> References: <20240701021216.17734-1-slark_xiao@163.com> <20240701021216.17734-2-slark_xiao@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240701021216.17734-2-slark_xiao@163.com> On Mon, Jul 01, 2024 at 10:12:15AM +0800, Slark Xiao wrote: > For SDX72 MBIM mode, it starts data mux id from 112 instead of 0. > This would lead to device can't ping outside successfully. > Also MBIM side would report "bad packet session (112)".In order to > fix this issue, we decide to use the device name of MHI controller > to do a match in client driver side. Then client driver could set > a corresponding mux_id value for this MHI product. > > Signed-off-by: Slark Xiao Applied to mhi-next with fixup to commit subject and description and also fixed the issue spotted by Jeff! - Mani > --- > v2: Remove Fix flag > v3: Use name match solution instead of use mux_id > v4: Update the description of new member 'name' and move it to > right position > --- > drivers/bus/mhi/host/pci_generic.c | 1 + > include/linux/mhi.h | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c > index 1fb1c2f2fe12..14a11880bcea 100644 > --- a/drivers/bus/mhi/host/pci_generic.c > +++ b/drivers/bus/mhi/host/pci_generic.c > @@ -1086,6 +1086,7 @@ static int mhi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) > mhi_cntrl->runtime_get = mhi_pci_runtime_get; > mhi_cntrl->runtime_put = mhi_pci_runtime_put; > mhi_cntrl->mru = info->mru_default; > + mhi_cntrl->name = info->name; > > if (info->edl_trigger) > mhi_cntrl->edl_trigger = mhi_pci_generic_edl_trigger; > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index b573f15762f8..d45058d3dbed 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -289,6 +289,7 @@ struct mhi_controller_config { > }; > > /** > + * @name: device name of the MHI controller > * struct mhi_controller - Master MHI controller structure > * @cntrl_dev: Pointer to the struct device of physical bus acting as the MHI > * controller (required) > @@ -367,6 +368,7 @@ struct mhi_controller_config { > * they can be populated depending on the usecase. > */ > struct mhi_controller { > + const char *name; > struct device *cntrl_dev; > struct mhi_device *mhi_dev; > struct dentry *debugfs_dentry; > -- > 2.25.1 > -- மணிவண்ணன் சதாசிவம்