public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Benjamin Tissoires <bentiss@kernel.org>,
	Jeff LaBundy <jeff@labundy.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/7] Input: evdev - remove ->event() method
Date: Wed,  3 Jul 2024 14:37:48 -0700	[thread overview]
Message-ID: <20240703213756.3375978-2-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20240703213756.3375978-1-dmitry.torokhov@gmail.com>

Input core favors ->events() (batch) method over ->event() method
if the former is defined, so there is no point in defining evdev_event()
as it is never called. Remove it.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/evdev.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c
index 51e0c4954600..05abcd45b5d4 100644
--- a/drivers/input/evdev.c
+++ b/drivers/input/evdev.c
@@ -308,17 +308,6 @@ static void evdev_events(struct input_handle *handle,
 	rcu_read_unlock();
 }
 
-/*
- * Pass incoming event to all connected clients.
- */
-static void evdev_event(struct input_handle *handle,
-			unsigned int type, unsigned int code, int value)
-{
-	struct input_value vals[] = { { type, code, value } };
-
-	evdev_events(handle, vals, 1);
-}
-
 static int evdev_fasync(int fd, struct file *file, int on)
 {
 	struct evdev_client *client = file->private_data;
@@ -1418,7 +1407,6 @@ static const struct input_device_id evdev_ids[] = {
 MODULE_DEVICE_TABLE(input, evdev_ids);
 
 static struct input_handler evdev_handler = {
-	.event		= evdev_event,
 	.events		= evdev_events,
 	.connect	= evdev_connect,
 	.disconnect	= evdev_disconnect,
-- 
2.45.2.803.g4e1b14247a-goog


  reply	other threads:[~2024-07-03 21:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03 21:37 [PATCH v2 0/7] Simplify event handling logic in input core Dmitry Torokhov
2024-07-03 21:37 ` Dmitry Torokhov [this message]
2024-07-07 19:53   ` [PATCH v2 1/7] Input: evdev - remove ->event() method Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 2/7] Input: make sure input handlers define only one processing method Dmitry Torokhov
2024-07-07 19:53   ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 3/7] Input: make events() method return number of events processed Dmitry Torokhov
2024-07-07 19:54   ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 4/7] Input: simplify event handling logic Dmitry Torokhov
2024-07-07 19:55   ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 5/7] Input: rearrange input_alloc_device() to prepare for preallocating of vals Dmitry Torokhov
2024-07-07 19:56   ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 6/7] Input: preallocate memory to hold event values Dmitry Torokhov
2024-07-07 19:56   ` Jeff LaBundy
2024-07-03 21:37 ` [PATCH v2 7/7] Input: do not check number of events in input_pass_values() Dmitry Torokhov
2024-07-07 19:57   ` Jeff LaBundy
2024-07-04  6:44 ` [PATCH v2 0/7] Simplify event handling logic in input core Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240703213756.3375978-2-dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=jeff@labundy.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox