From: Greg KH <gregkh@linuxfoundation.org>
To: Vamsi Attunuru <vattunuru@marvell.com>
Cc: arnd@arndb.de, jerinj@marvell.com, schalla@marvell.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver
Date: Wed, 3 Jul 2024 16:33:27 +0200 [thread overview]
Message-ID: <2024070333-matchless-batch-57ec@gregkh> (raw)
In-Reply-To: <20240619132109.3168940-1-vattunuru@marvell.com>
On Wed, Jun 19, 2024 at 06:21:09AM -0700, Vamsi Attunuru wrote:
> +struct dpi_mps_mrrs_cfg {
> + __u16 max_read_req_sz; /* Max read request size */
> + __u16 max_payload_sz; /* Max payload size */
> + __u16 port; /* Ebus port */
> + __u16 rsvd; /* Reserved */
Please spell out "reserved" you have plenty of characters to use.
Anyway, you NEVER check this, so you just made it so it can never be
used. Please read the documentation in the kernel for how to add new
ioctls, it goes through the reasoning why you must check this for 0 now.
thanks,
greg k-h
next prev parent reply other threads:[~2024-07-03 14:33 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 3:55 [PATCH 1/1] misc: mrvl-dpi: add octeontx3 dpi driver Vamsi Attunuru
2024-02-14 10:50 ` Greg KH
2024-02-14 11:40 ` [EXT] " Vamsi Krishna Attunuru
2024-02-14 11:22 ` Arnd Bergmann
2024-02-14 13:33 ` [EXT] " Vamsi Krishna Attunuru
2024-02-16 10:32 ` [PATCH v2 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K " Vamsi Attunuru
2024-02-17 8:13 ` Greg KH
2024-02-19 5:03 ` [EXT] " Vamsi Krishna Attunuru
2024-02-19 6:18 ` Greg KH
2024-02-19 7:03 ` Vamsi Krishna Attunuru
2024-02-28 16:21 ` [PATCH v3 1/1] misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver Vamsi Attunuru
2024-03-07 21:55 ` Greg KH
2024-03-08 11:36 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-03-12 10:56 ` [PATCH v4 " Vamsi Attunuru
2024-04-11 13:02 ` Greg KH
2024-04-12 6:34 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-04-12 12:10 ` [PATCH v5 " Vamsi Attunuru
2024-04-12 12:26 ` Greg KH
2024-04-12 13:56 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-04-12 15:34 ` Greg KH
2024-04-12 16:19 ` Vamsi Krishna Attunuru
2024-04-13 5:47 ` Greg KH
2024-04-13 10:58 ` Vamsi Krishna Attunuru
2024-04-13 11:25 ` Greg KH
2024-04-13 16:17 ` Vamsi Krishna Attunuru
2024-04-13 19:11 ` Arnd Bergmann
2024-04-14 9:33 ` Vamsi Krishna Attunuru
2024-04-14 9:46 ` Greg Kroah-Hartman
2024-04-14 12:32 ` Vamsi Krishna Attunuru
2024-04-25 13:36 ` Vamsi Krishna Attunuru
2024-04-26 1:04 ` Greg KH
2024-04-26 18:20 ` [PATCH v6 " Vamsi Attunuru
2024-04-27 11:06 ` Greg KH
2024-04-27 11:59 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-04-29 5:50 ` Vamsi Attunuru
2024-04-29 9:13 ` Greg KH
2024-05-01 7:46 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-05-01 8:02 ` Greg KH
2024-05-20 11:06 ` [PATCH v7 " Vamsi Attunuru
2024-06-04 15:52 ` Greg KH
2024-06-04 16:21 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-06-05 11:57 ` Arnd Bergmann
2024-06-06 8:58 ` Vamsi Krishna Attunuru
2024-06-06 16:42 ` Vamsi Krishna Attunuru
2024-06-08 8:42 ` Arnd Bergmann
2024-06-17 12:55 ` Vamsi Krishna Attunuru
2024-06-17 13:23 ` Arnd Bergmann
2024-06-18 13:09 ` [PATCH v8 " Vamsi Attunuru
2024-06-18 14:19 ` Arnd Bergmann
2024-06-19 13:21 ` [PATCH v9 " Vamsi Attunuru
2024-07-03 14:33 ` Greg KH [this message]
2024-07-03 16:30 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-07-06 15:30 ` [PATCH v10 " Vamsi Attunuru
2024-07-10 12:58 ` Greg KH
2024-07-10 13:19 ` [EXTERNAL] " Vamsi Krishna Attunuru
2024-07-10 13:27 ` Greg KH
2024-07-10 13:48 ` Vamsi Krishna Attunuru
2024-07-10 14:11 ` Greg KH
2024-07-12 8:44 ` Vamsi Krishna Attunuru
2024-07-12 8:54 ` Greg KH
2024-07-17 3:55 ` Jeff Johnson
2024-07-10 14:03 ` Arnd Bergmann
2024-04-30 14:00 ` [PATCH v6 " kernel test robot
2024-04-30 14:22 ` kernel test robot
2024-04-30 15:36 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070333-matchless-batch-57ec@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jerinj@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schalla@marvell.com \
--cc=vattunuru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox