Re: [PATCH 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic A4/A5 Reset Controller

Neil Armstrong
2024-07-03T07:42:14Z

On 03/07/2024 08:16, zelong dong wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
>
> Add new compatible and DT bindings for Amlogic A4/A5 Reset Controller
>
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> ---
> .../bindings/reset/amlogic,meson-reset.yaml | 22 +++++++++++++------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> index f0c6c0df0ce3..80345af81d5a 100644
> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> @@ -12,13 +12,21 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
> - - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
> - - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
> - - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
> - - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
> - - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
> + oneOf:
> + - items:
> + - enum:
> + - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
> + - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
> + - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
> + - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
> + - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
> + - amlogic,t7-reset
> + - items:
> + - enum:
> + - amlogic,a4-reset
> + - amlogic,a5-reset
> + - amlogic,c3-reset
> + - const: amlogic,meson-s4-reset

Here you're changing bindings for amlogic,c3-reset, move it in the other enum list.

Neil

>
> reg:
> maxItems: 1