From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johan Hovold <johan+linaro@kernel.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] serial: qcom-geni: fix lockups
Date: Thu, 4 Jul 2024 12:30:52 +0200 [thread overview]
Message-ID: <2024070445-stunner-scrawny-1b03@gregkh> (raw)
In-Reply-To: <20240704101805.30612-1-johan+linaro@kernel.org>
On Thu, Jul 04, 2024 at 12:18:02PM +0200, Johan Hovold wrote:
> Since 6.10-rc1, Qualcomm machines with a serial port can easily lock up
> hard, for example, when stopping a getty on reboot.
>
> This was triggered by the kfifo conversion, which turned an existing bug
> that caused the driver to print discarded characters after a buffer
> flush into a hard lockup.
>
> This series fixes the regression and a related soft lockup issue that
> can be triggered on software flow control and on suspend.
>
> Doug has posted an alternative series of fixes here that depends on
> reworking the driver a fair bit here:
>
> https://lore.kernel.org/lkml/20240610222515.3023730-1-dianders@chromium.org/
>
> This rework has a significant impact on performance on some platforms,
> but fortunately it seems such a rework can be avoided.
>
> There are further bugs in the console code (e.g. that can lead to lost
> characters) that this series does not address, but those can be fixed
> separately (and I've started working on that).
I'll take these now, thanks!
greg k-h
next prev parent reply other threads:[~2024-07-04 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 10:18 [PATCH v2 0/3] serial: qcom-geni: fix lockups Johan Hovold
2024-07-04 10:18 ` [PATCH v2 1/3] serial: qcom-geni: fix soft lockup on sw flow control and suspend Johan Hovold
2024-07-04 10:18 ` [PATCH v2 2/3] serial: qcom-geni: fix hard lockup on buffer flush Johan Hovold
2024-07-04 10:18 ` [PATCH v2 3/3] serial: qcom-geni: do not kill the machine on fifo underrun Johan Hovold
2024-07-08 23:59 ` Doug Anderson
2024-07-09 9:44 ` Johan Hovold
2024-07-09 12:55 ` Johan Hovold
2024-07-09 23:30 ` Doug Anderson
2024-07-04 10:30 ` Greg Kroah-Hartman [this message]
2024-07-08 23:57 ` [PATCH v2 0/3] serial: qcom-geni: fix lockups Doug Anderson
2024-07-09 9:32 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024070445-stunner-scrawny-1b03@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andersson@kernel.org \
--cc=dianders@chromium.org \
--cc=jirislaby@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox