Re: [PATCH v1 2/4] x86/fred: Write to FRED MSRs with wrmsrns()

Dave Hansen
2024-07-03T15:43:49Z

On 7/3/24 01:54, Xin Li (Intel) wrote:
> Do FRED MSR writes with wrmsrns() rather than wrmsrl().

A longer changelog would be appreciated here. The wrmsrns() is
presumably to avoid the WRMSR serialization overhead and the CR4 write
provides all of the serialization that we need.

I'm also not clear how this fits into the series other than being FRED
related.

> No functional change intended.

I think I know what this was trying to convey, but I'm not sure this
phrase is appropriate to use here. Sure, WRMSR and WRMSRNS have the
same general purpose, but I'd never say they are functionally equivalent.