Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled

Bartosz Golaszewski
2024-07-08T06:52:32Z

On Mon, 8 Jul 2024 at 02:37, Krzysztof Wilczyński <kw@linux.com> wrote:
>
> Hello,
>
> > > If of_platform_populate() is called when CONFIG_OF is not defined this
> > > leads to spurious error messages of the following type:
> > > pci 0000:00:01.1: failed to populate child OF nodes (-19)
> > > pci 0000:00:02.1: failed to populate child OF nodes (-19)
> > >
> > > Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
> > >
> > > Signed-off-by: Bert Karwatzki <spasswolf@web.de>
> >
> > Reported-by: Praveenkumar Patil <PraveenKumar.Patil@amd.com>
> > Closes: https://lore.kernel.org/all/20240702173255.39932-1-superm1@kernel.org/
> > Reviewed-by: Lukas Wunner <lukas@wunner.de>
> > Cc: Mario Limonciello <mario.limonciello@amd.com>
>
> If there aren't any objections, I will take this via the PCI tree, and add
> the missing tags. So, no need to send a new version of this patch.
>
> Thank you for the work here! Appreciated.
>
> Krzysztof

I don't think you can take it via the PCI tree as it depends on the
changes that went via the new pwrseq tree (with Bjorn's blessing).
Please leave your Ack here and I will take it with the other PCI
pwrctl changes.

After the upcoming merge window we should go back to normal.

Bart