Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled

Bjorn Helgaas
2024-07-08T19:13:36Z

On Sun, Jul 07, 2024 at 08:38:28PM +0200, Bert Karwatzki wrote:
> If of_platform_populate() is called when CONFIG_OF is not defined this
> leads to spurious error messages of the following type:
> pci 0000:00:01.1: failed to populate child OF nodes (-19)
> pci 0000:00:02.1: failed to populate child OF nodes (-19)
>
> Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
>
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>

I didn't trace all the history of this patch so I don't know whether
it's in or out. If it hasn't been applied yet or will be revised, run
"git log --oneline drivers/pci/bus.c" and match the style, e.g.,

PCI/pwrctl: Call of_platform_populate() only when CONFIG_OF enabled

This would also match the 8fb18619d910 subject so it's more obvious
they are connected.

Bjorn