public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: alexs@kernel.org
To: alexs@kernel.org
Cc: 42.hyeyoo@gmail.com, akpm@linux-foundation.org, david@redhat.com,
	linmiaohe@huawei.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, minchan@kernel.org, nphamcs@gmail.com,
	senozhatsky@chromium.org, vitaly.wool@konsulko.com,
	willy@infradead.org, yosryahmed@google.com,
	kernel test robot <lkp@intel.com>
Subject: [PATCH] mm/zsmalloc: fix build warning from lkp testing
Date: Mon,  8 Jul 2024 15:42:23 +0800	[thread overview]
Message-ID: <20240708074223.1113744-1-alexs@kernel.org> (raw)
In-Reply-To: <20240708063344.1096626-18-alexs@kernel.org>

From: "Alex Shi (Tencent)" <alexs@kernel.org>

LKP reported the following warning w/o CONFIG_DEBUG_VM:
	mm/zsmalloc.c:471:12: warning: function 'is_first_zpdesc' is not
	needed and will not be emitted [-Wunneeded-internal-declaration]
To remove this warning, better to incline the function is_first_zpdesc

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407052102.qbT7nLMK-lkp@intel.com/
Signed-off-by: Alex Shi (Tencent) <alexs@kernel.org>
---
 mm/zsmalloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 7f8e02df4e3e..64e523ae71f8 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -468,7 +468,7 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area) = {
 	.lock	= INIT_LOCAL_LOCK(lock),
 };
 
-static int is_first_zpdesc(struct zpdesc *zpdesc)
+static inline bool is_first_zpdesc(struct zpdesc *zpdesc)
 {
 	return PagePrivate(zpdesc_page(zpdesc));
 }
-- 
2.43.0


  reply	other threads:[~2024-07-08  7:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-08  6:33 [PATCH v3 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool alexs
2024-07-08  6:33 ` [PATCH v3 01/20] " alexs
2024-07-08  6:33 ` [PATCH v3 02/20] mm/zsmalloc: use zpdesc in trylock_zspage/lock_zspage alexs
2024-07-08  6:33 ` [PATCH v3 03/20] mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc alexs
2024-07-08  6:33 ` [PATCH v3 04/20] mm/zsmalloc: add and use pfn/zpdesc seeking funcs alexs
2024-07-08  6:33 ` [PATCH v3 05/20] mm/zsmalloc: convert obj_malloc() to use zpdesc alexs
2024-07-08  6:33 ` [PATCH v3 06/20] mm/zsmalloc: convert create_page_chain() and its users " alexs
2024-07-08  6:33 ` [PATCH v3 07/20] mm/zsmalloc: convert obj_allocated() and related helpers " alexs
2024-07-08  6:33 ` [PATCH v3 08/20] mm/zsmalloc: convert init_zspage() " alexs
2024-07-08  6:33 ` [PATCH v3 09/20] mm/zsmalloc: convert obj_to_page() and zs_free() " alexs
2024-07-08  6:33 ` [PATCH v3 10/20] mm/zsmalloc: add zpdesc_is_isolated/zpdesc_zone helper for zs_page_migrate alexs
2024-07-08  6:33 ` [PATCH v3 11/20] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it alexs
2024-07-08  6:33 ` [PATCH v3 12/20] mm/zsmalloc: convert __free_zspage() to use zdsesc alexs
2024-07-08  6:33 ` [PATCH v3 13/20] mm/zsmalloc: convert location_to_obj() to take zpdesc alexs
2024-07-08  6:33 ` [PATCH v3 14/20] mm/zsmalloc: convert migrate_zspage() to use zpdesc alexs
2024-07-08  6:33 ` [PATCH v3 15/20] mm/zsmalloc: convert get_zspage() to take zpdesc alexs
2024-07-08  6:33 ` [PATCH v3 16/20] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs alexs
2024-07-08  6:33 ` [PATCH v3 17/20] mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc alexs
2024-07-08  7:42   ` alexs [this message]
2024-07-08  6:33 ` [PATCH v3 18/20] mm/zsmalloc: introduce __zpdesc_clear_movable alexs
2024-07-08  6:33 ` [PATCH v3 19/20] mm/zsmalloc: introduce __zpdesc_clear_zsmalloc alexs
2024-07-08  6:33 ` [PATCH v3 20/20] mm/zsmalloc: introduce __zpdesc_set_zsmalloc() alexs
2024-07-15  1:33 ` [PATCH v3 00/20] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool Alex Shi
2024-07-15 16:21   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708074223.1113744-1-alexs@kernel.org \
    --to=alexs@kernel.org \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=minchan@kernel.org \
    --cc=nphamcs@gmail.com \
    --cc=senozhatsky@chromium.org \
    --cc=vitaly.wool@konsulko.com \
    --cc=willy@infradead.org \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox