Re: [PATCH v3 1/1] HP: wmi: added support for 4 zone keyboard rgb

kernel test robot
2024-07-07T22:22:48Z

Hi Carlos,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.10-rc6 next-20240703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Carlos-Ferreira/HP-wmi-added-support-for-4-zone-keyboard-rgb/20240708-015808
base: linus/master
patch link: https://lore.kernel.org/r/20240707175613.27529-2-carlosmiguelferreira.2003%40gmail.com
patch subject: [PATCH v3 1/1] HP: wmi: added support for 4 zone keyboard rgb
config: i386-randconfig-001-20240708 (https://download.01.org/0day-ci/archive/20240708/202407080657.XLHI1WRv-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240708/202407080657.XLHI1WRv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407080657.XLHI1WRv-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/platform/x86/hp/hp-wmi.c:1590:28: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1590 | buff[25 + zone * 3] = FIELD_GET(FOURZONE_COLOR_R, color);
| ^
>> drivers/platform/x86/hp/hp-wmi.c:1609:15: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
1609 | colors[i] = FIELD_PREP(FOURZONE_COLOR_R, buff[25 + i * 3])
| ^
2 errors generated.

vim +/FIELD_GET +1590 drivers/platform/x86/hp/hp-wmi.c

1579
1580 static int fourzone_set_colors(u32 color, size_t zone)
1581 {
1582 u8 buff[128];
1583 int ret;
1584
1585 ret = hp_wmi_perform_query(HPWMI_FOURZONE_COLOR_GET, HPWMI_FOURZONE,
1586 &buff, sizeof(buff), sizeof(buff));
1587 if (ret != 0)
1588 return -EINVAL;
1589
> 1590 buff[25 + zone * 3] = FIELD_GET(FOURZONE_COLOR_R, color);
1591 buff[25 + zone * 3 + 1] = FIELD_GET(FOURZONE_COLOR_G, color);
1592 buff[25 + zone * 3 + 2] = FIELD_GET(FOURZONE_COLOR_B, color);
1593
1594 return hp_wmi_perform_query(HPWMI_FOURZONE_COLOR_SET, HPWMI_FOURZONE,
1595 &buff, sizeof(buff), sizeof(buff));
1596 }
1597
1598 static int fourzone_get_colors(u32 *colors)
1599 {
1600 u8 buff[128];
1601 int ret;
1602
1603 ret = hp_wmi_perform_query(HPWMI_FOURZONE_COLOR_GET, HPWMI_FOURZONE,
1604 &buff, sizeof(buff), sizeof(buff));
1605 if (ret != 0)
1606 return -EINVAL;
1607
1608 for (int i = 0; i < 4; i++) {
> 1609 colors[i] = FIELD_PREP(FOURZONE_COLOR_R, buff[25 + i * 3])
1610 | FIELD_PREP(FOURZONE_COLOR_G, buff[25 + i * 3 + 1])
1611 | FIELD_PREP(FOURZONE_COLOR_B, buff[25 + i * 3 + 2]);
1612 }
1613
1614 return 0;
1615 }
1616

--
0-DAY CI Kernel Test Service