[PATCH] linux/interrupt.h: fix struct irqaction comment order inconsistency

[PATCH] linux/interrupt.h: fix struct irqaction comment order inconsistency

[ChengChaoChun]

Rearrange struct irqaction comment to match member order in the code.

Signed-off-by: ChengChaoChun <abc21531050@gmail.com>
---
 include/linux/interrupt.h | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 5c9bdd3ffccc..b405e181829b 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -104,19 +104,19 @@ typedef irqreturn_t (*irq_handler_t)(int, void *);
 
 /**
  * struct irqaction - per interrupt action descriptor
- * @handler:	interrupt handler function
- * @name:	name of the device
- * @dev_id:	cookie to identify the device
- * @percpu_dev_id:	cookie to identify the device
- * @next:	pointer to the next irqaction for shared interrupts
- * @irq:	interrupt number
- * @flags:	flags (see IRQF_* above)
- * @thread_fn:	interrupt handler function for threaded interrupts
- * @thread:	thread pointer for threaded interrupts
- * @secondary:	pointer to secondary irqaction (force threading)
- * @thread_flags:	flags related to @thread
- * @thread_mask:	bitmask for keeping track of @thread activity
- * @dir:	pointer to the proc/irq/NN/name entry
+ * @handler:    interrupt handler function
+ * @dev_id:     cookie to identify the device
+ * @percpu_dev_id:      cookie to identify the device
+ * @next:       pointer to the next irqaction for shared interrupts
+ * @thread_fn:  interrupt handler function for threaded interrupts
+ * @thread:     thread pointer for threaded interrupts
+ * @secondary:  pointer to secondary irqaction (force threading)
+ * @irq:        interrupt number
+ * @flags:      flags (see IRQF_* above)
+ * @thread_flags:       flags related to @thread
+ * @thread_mask:        bitmask for keeping track of @thread activity
+ * @name:       name of the device
+ * @dir:        pointer to the proc/irq/NN/name entry
  */
 struct irqaction {
 	irq_handler_t		handler;
-- 
2.34.1

Re: [PATCH] linux/interrupt.h: fix struct irqaction comment order inconsistency

[Thomas Gleixner]

On Tue, Jul 09 2024 at 00:06, ChengChaoChun wrote:
>  /**
>   * struct irqaction - per interrupt action descriptor
> - * @handler:	interrupt handler function
> - * @name:	name of the device
> - * @dev_id:	cookie to identify the device
> - * @percpu_dev_id:	cookie to identify the device
> - * @next:	pointer to the next irqaction for shared interrupts
> - * @irq:	interrupt number
> - * @flags:	flags (see IRQF_* above)
> - * @thread_fn:	interrupt handler function for threaded interrupts
> - * @thread:	thread pointer for threaded interrupts
> - * @secondary:	pointer to secondary irqaction (force threading)
> - * @thread_flags:	flags related to @thread
> - * @thread_mask:	bitmask for keeping track of @thread activity
> - * @dir:	pointer to the proc/irq/NN/name entry
> + * @handler:    interrupt handler function

This changes tabs to spaces ....

> + * @dev_id:     cookie to identify the device
> + * @percpu_dev_id:      cookie to identify the device
> + * @next:       pointer to the next irqaction for shared interrupts
> + * @thread_fn:  interrupt handler function for threaded interrupts
> + * @thread:     thread pointer for threaded interrupts
> + * @secondary:  pointer to secondary irqaction (force threading)
> + * @irq:        interrupt number
> + * @flags:      flags (see IRQF_* above)
> + * @thread_flags:       flags related to @thread
> + * @thread_mask:        bitmask for keeping track of @thread activity

And while at it, please align all members in a tabular fashion.

Thanks,

        tglx