From: Bjorn Helgaas <helgaas@kernel.org>
To: Bert Karwatzki <spasswolf@web.de>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
caleb.connolly@linaro.org, bhelgaas@google.com,
amit.pundir@linaro.org, neil.armstrong@linaro.org,
Lukas Wunner <lukas@wunner.de>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled
Date: Mon, 8 Jul 2024 14:13:28 -0500 [thread overview]
Message-ID: <20240708191328.GA144620@bhelgaas> (raw)
In-Reply-To: <20240707183829.41519-1-spasswolf@web.de>
On Sun, Jul 07, 2024 at 08:38:28PM +0200, Bert Karwatzki wrote:
> If of_platform_populate() is called when CONFIG_OF is not defined this
> leads to spurious error messages of the following type:
> pci 0000:00:01.1: failed to populate child OF nodes (-19)
> pci 0000:00:02.1: failed to populate child OF nodes (-19)
>
> Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
>
> Signed-off-by: Bert Karwatzki <spasswolf@web.de>
I didn't trace all the history of this patch so I don't know whether
it's in or out. If it hasn't been applied yet or will be revised, run
"git log --oneline drivers/pci/bus.c" and match the style, e.g.,
PCI/pwrctl: Call of_platform_populate() only when CONFIG_OF enabled
This would also match the 8fb18619d910 subject so it's more obvious
they are connected.
Bjorn
next prev parent reply other threads:[~2024-07-08 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 18:38 [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG_OF is enabled Bert Karwatzki
2024-07-07 18:47 ` Lukas Wunner
2024-07-08 0:37 ` Krzysztof Wilczyński
2024-07-08 6:52 ` Bartosz Golaszewski
2024-07-08 8:33 ` Krzysztof Wilczyński
2024-07-08 15:29 ` Mario Limonciello
2024-07-08 15:34 ` Bartosz Golaszewski
2024-07-08 15:44 ` Manivannan Sadhasivam
2024-07-08 15:46 ` Mario Limonciello
2024-07-08 15:49 ` Bartosz Golaszewski
2024-07-08 15:53 ` Mario Limonciello
2024-07-08 15:58 ` Bartosz Golaszewski
2024-07-08 16:01 ` Mario Limonciello
2024-07-08 15:58 ` Manivannan Sadhasivam
2024-07-08 7:22 ` Manivannan Sadhasivam
2024-07-08 9:54 ` Bartosz Golaszewski
2024-07-08 9:55 ` Bartosz Golaszewski
2024-07-08 19:13 ` Bjorn Helgaas [this message]
2024-07-08 19:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240708191328.GA144620@bhelgaas \
--to=helgaas@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=caleb.connolly@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=neil.armstrong@linaro.org \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox