[PATCH v2] driver:core: no need to invert the return value of the call_driver_probe()

[PATCH v2] driver:core: no need to invert the return value of the call_driver_probe()

[Lizhe]

If drv->probe() or drv->bus->probe() returns EPROBE_DEFER,
then there is no need to invert the sign. Similarly,
if it returns -EPROBE_DEFER, no sign inversion is needed either

In the probe function (either bus->probe() or drv->probe()),
there is no return value of EPROBE_DEFER.
v2:
        Delete the judgment with the return value of EPROBEDEFER
        from the _driver_probe.device()
v1:
        Add the judgment with the return value of EPROBEDEFER
        from the _driver_probe.device()

Signed-off-by: Lizhe <sensor1010@163.com>
---
 drivers/base/dd.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 83d352394fdf..d047919d1f5e 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -664,11 +664,6 @@ static int really_probe(struct device *dev, struct device_driver *drv)
 		if (link_ret == -EAGAIN)
 			ret = -EPROBE_DEFER;
 
-		/*
-		 * Return probe errors as positive values so that the callers
-		 * can distinguish them from other errors.
-		 */
-		ret = -ret;
 		goto probe_failed;
 	}
 
@@ -826,7 +821,7 @@ static int driver_probe_device(struct device_driver *drv, struct device *dev)
 
 	atomic_inc(&probe_count);
 	ret = __driver_probe_device(drv, dev);
-	if (ret == -EPROBE_DEFER || ret == EPROBE_DEFER) {
+	if (ret == -EPROBE_DEFER) {
 		driver_deferred_probe_add(dev);
 
 		/*
-- 
2.17.1

Re: [PATCH v2] driver:core: no need to invert the return value of the call_driver_probe()

[Greg KH]

On Mon, Jul 08, 2024 at 06:40:28AM -0700, Lizhe wrote:
> If drv->probe() or drv->bus->probe() returns EPROBE_DEFER,
> then there is no need to invert the sign. Similarly,
> if it returns -EPROBE_DEFER, no sign inversion is needed either
> 
> In the probe function (either bus->probe() or drv->probe()),
> there is no return value of EPROBE_DEFER.
> v2:
>         Delete the judgment with the return value of EPROBEDEFER
>         from the _driver_probe.device()
> v1:
>         Add the judgment with the return value of EPROBEDEFER
>         from the _driver_probe.device()

Versions go below the --- line as the documentation says.

> Signed-off-by: Lizhe <sensor1010@163.com>

Full name?

thanks,

greg k-h

Re: Re: [PATCH v2] driver:core: no need to invert the return value of the call_driver_probe()

[Greg KH]

On Tue, Jul 09, 2024 at 10:20:42PM +0800, lizhe wrote:
> 
> 
> 
> Hi， Greg KH
> 
> 
> 
> 
> have already submitted the third version. My name is 李哲. In pinyin, it's Lizhe, and my email is sensor1010@163.com

Why not just use "李哲"?  No reason we can't use the proper
representation of your name in the changelog, right?

thanks,

greg k-h