Re: [PATCH 6.9 000/197] 6.9.9-rc1 review

Mark Brown
2024-07-10T13:05:01Z

[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]

On Tue, Jul 09, 2024 at 01:07:34PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.9.9 release.
> There are 197 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

I'm seeing the RTC date_read_loop test start triggering timeouts on the
i.MX8MP EVK with this:

# # RUN rtc.date_read_loop ...
# # rtctest.c:95:date_read_loop:Continuously reading RTC time for 30s (with 11ms breaks after every read).
# # date_read_loop: Test terminated by timeout

The test was fine with v6.10-rc3 (the first tag it worked at all for
v6.10 but that's another story...), but is broken in -next:

# # RUN rtc.date_read_loop ...
# # rtctest.c:95:date_read_loop:Continuously reading RTC time for 30s (with 11ms breaks after every read).
# # rtctest.c:122:date_read_loop:Performed 2954 RTC time reads.
# # OK rtc.date_read_loop

Bisection points to "selftests/harness: Fix tests timeout and race
condition" but this looks like a test bug, the timeout for tests is 30s
and the test tries to run for 30s which obviously doesn't add up.
Previously the test would pass because the bug the patch is fixing is
that timeout had no effect. I'm also running the test on other
platforms without it triggering new timeouts, it's just this one
specific platform that triggered which is a bit worrying.

I'll send a patch for the test.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]