From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 873DF139563 for ; Tue, 9 Jul 2024 11:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720525870; cv=none; b=ssZmrctkfhnGZptQh7YqMJeIMqDJOKqXdxXD6ieenYTQY0N/r6eA/hY0/38KzqAbOQDAllvjfSVLxa9/472TcY+xllolfvIp5HWug5G/sh4E6fDLv1ROatZPl5THkbTYC78carWZLWSBTEXd8NaEZCuJkN4EO23rNvR7TYSQv1M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720525870; c=relaxed/simple; bh=9J7/VvorApxZyEwc6503bE/xVbF4fVh6GpJw6bgEdEk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HJrs0JXqXDVIK+ZsKTmur7TLf26KRq3dvfPjhbMdvpG/TkNAzl446fJ2QAc/IUFGy97biMMgbz49Bq7Dm/JWxK/aWRuWGhwEosLodJWVHn3XVxJ+W6UzufFQpCFloY1C7V0I+EzpZqS/S8MHDZLH4EqscxVtVTuPPdCqmdjXLrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id C293268BEB; Tue, 9 Jul 2024 13:51:03 +0200 (CEST) Date: Tue, 9 Jul 2024 13:51:03 +0200 From: Christoph Hellwig To: Michael Kelley Cc: Christoph Hellwig , "robin.murphy@arm.com" , "joro@8bytes.org" , "will@kernel.org" , "jgross@suse.com" , "sstabellini@kernel.org" , "oleksandr_tyshchenko@epam.com" , "m.szyprowski@samsung.com" , "petr@tesarici.cz" , "iommu@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 1/1] swiotlb: Reduce swiotlb pool lookups Message-ID: <20240709115103.GA7662@lst.de> References: <20240708194100.1531-1-mhklinux@outlook.com> <20240709062555.GB16797@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jul 09, 2024 at 11:48:08AM +0000, Michael Kelley wrote: > Your tweaks look fine to me. Evidently I misunderstood your > preference in our previous exchange about #ifdef vs. IS_ENABLED() > in swiotlb_find_pool(), and the effect on dma_uses_io_tlb. Actually I actively mislead you. Yes, I prefer the IS_ENABLED, but I missed that it would require make the field available unconditionally, which is not worth the tradeoff. Sorry for that.