From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63DF1AB517; Tue, 9 Jul 2024 16:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542402; cv=none; b=rQ2tEmR/eEtl3385QJ8TYZE/rvLxHn6V1kdf11a8dHtcrgku2IazNKpJ+gVOaTm9tWP2dL/zYqTYIkg0U99uXezGiYAAVOKtudtuxF1ZhoWYAIARaFhp/T6LLgWTle9po9yC5ux+ymCYh4QX7d5QHXEQUsaakmMB6so/MM3b4qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542402; c=relaxed/simple; bh=/XVfUO0TG+w3sZ0VPaMx+hwQdSVqSIRr2m1mCLNFpWE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iET+ehE/wVVJIR7xseeoILTBQfB3RuNq91Ab2mk3bIYBJIkuTdI1boSSglyHV4y+uyBALCnqmBtsaU4IR/nTFMlKNN0TAsDGy5ayJI2ZabjFUjhRtnTXB9jXfzZrWACnlTZrFbjXPWD+7BPGw0notT1Pkrtj81aT1lgMChEvTXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j8JYunlC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j8JYunlC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A79CC32782; Tue, 9 Jul 2024 16:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720542402; bh=/XVfUO0TG+w3sZ0VPaMx+hwQdSVqSIRr2m1mCLNFpWE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=j8JYunlClTRAGFxhivp9QyOKnM9Np9Fr85O6qQL6qOL4IW19IO800dZiiZ+Vp+1ix 0ey5ZGSQMA6/zlxnGWYpLNSY7nkxxz3bZHUc5QrtRl8llQ03BbfUrg+f471pcyBx2v jdAYNqpEn/HC5SR3rruZtj55KrJLYfCs83XYKwizFv2EcNogrj4xyJIZrs+lmyggQP 7CmIMh0/A1j2nA3CFVpnvp86dqUHF0MTzJEzf1bbtra2pMY1ZVXXbxdLWpZQdE422X udsICNAjnKAfI/qf7qALumM57NpoMHGS+Egf7HNQGqjEyw9O5pXSFl3Z2DWtIbJ/RE pZQnS8wEYifuw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Shengjiu Wang , Takashi Iwai , Sasha Levin , lars@metafoo.de, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 13/14] ALSA: dmaengine_pcm: terminate dmaengine before synchronize Date: Tue, 9 Jul 2024 12:25:57 -0400 Message-ID: <20240709162612.32988-13-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240709162612.32988-1-sashal@kernel.org> References: <20240709162612.32988-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.221 Content-Transfer-Encoding: 8bit From: Shengjiu Wang [ Upstream commit 6a7db25aad8ce6512b366d2ce1d0e60bac00a09d ] When dmaengine supports pause function, in suspend state, dmaengine_pause() is called instead of dmaengine_terminate_async(), In end of playback stream, the runtime->state will go to SNDRV_PCM_STATE_DRAINING, if system suspend & resume happen at this time, application will not resume playback stream, the stream will be closed directly, the dmaengine_terminate_async() will not be called before the dmaengine_synchronize(), which violates the call sequence for dmaengine_synchronize(). This behavior also happens for capture streams, but there is no SNDRV_PCM_STATE_DRAINING state for capture. So use dmaengine_tx_status() to check the DMA status if the status is DMA_PAUSED, then call dmaengine_terminate_async() to terminate dmaengine before dmaengine_synchronize(). Signed-off-by: Shengjiu Wang Link: https://patch.msgid.link/1718851218-27803-1-git-send-email-shengjiu.wang@nxp.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/core/pcm_dmaengine.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/sound/core/pcm_dmaengine.c b/sound/core/pcm_dmaengine.c index db22294452560..a7e2e6955e51c 100644 --- a/sound/core/pcm_dmaengine.c +++ b/sound/core/pcm_dmaengine.c @@ -359,6 +359,12 @@ EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_sync_stop); int snd_dmaengine_pcm_close(struct snd_pcm_substream *substream) { struct dmaengine_pcm_runtime_data *prtd = substream_to_prtd(substream); + struct dma_tx_state state; + enum dma_status status; + + status = dmaengine_tx_status(prtd->dma_chan, prtd->cookie, &state); + if (status == DMA_PAUSED) + dmaengine_terminate_async(prtd->dma_chan); dmaengine_synchronize(prtd->dma_chan); kfree(prtd); @@ -377,6 +383,12 @@ EXPORT_SYMBOL_GPL(snd_dmaengine_pcm_close); int snd_dmaengine_pcm_close_release_chan(struct snd_pcm_substream *substream) { struct dmaengine_pcm_runtime_data *prtd = substream_to_prtd(substream); + struct dma_tx_state state; + enum dma_status status; + + status = dmaengine_tx_status(prtd->dma_chan, prtd->cookie, &state); + if (status == DMA_PAUSED) + dmaengine_terminate_async(prtd->dma_chan); dmaengine_synchronize(prtd->dma_chan); dma_release_channel(prtd->dma_chan); -- 2.43.0