From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A13791B79FE; Tue, 9 Jul 2024 16:27:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542460; cv=none; b=ORQGX4n39gbbsPtidXgFIThsTj7NO+Ei7Uk/2dsL2bOBLPqPzKMteNntYNxJbqKYfdQvXRlX9hs0gXuMBr4hTLuvllWKncwXPOhwZKvyqJnWPC+RWt0rNim1pKJ9/2NHoa0kbO3fBjd2zsyhn31oSQjZ7cRBmHdawDKTiygvdSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720542460; c=relaxed/simple; bh=p6QFn0Qv9jjcD4ZWqgmqNvDvAzjuLN+Ds4X9ap7k+Sw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GIIjLxrxl+SqwPKBIBnIWQYX75JDn47eTtJNlcQ1MxkuWv6zQV43CoB6LZHv5UOTWmxUnv/47XwFRKWQ5M/BGBpTtdgIY/oi4N8uu8kjOXl+kWRRRpsX/yTWQc4+ocW5+6P/hnSKIBBvsluvb9ie04l3iZ85Lc7vLQc41SljZwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t+UtlPof; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t+UtlPof" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 213A2C32782; Tue, 9 Jul 2024 16:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720542460; bh=p6QFn0Qv9jjcD4ZWqgmqNvDvAzjuLN+Ds4X9ap7k+Sw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t+UtlPofEkk8l2K2pAEqG5ci42W7u5tIp24JZ+YVg0R71wfMh6L789mves0kolYSV iI5qRnrJd5rZnnqj6vNFUgxDSHSMD7V4aA6tnusbjgkDtWXDcDaDLFXPc8xGig5mFf k/17dOajhX5ckAsG9Jm24Fu7ivZgIjSLvs+ucS1pyBA0bjhyqrtETSFOAGoMwx9UC+ NF0oqPtvBN/icXFuIMI+Lw0kDAYCulPGBk3psXsOuaa+z9px9TJ3T79JXrN1DcVc9k bmMqQu/fkRcqbm2D9rRHgTmQve0nZqeA6X7cetWIUFp5BeCG1DzgHkeADg4ZRVCzUl nVVNQfFjCp/+g== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Heiko Carstens , Peter Oberparleiter , Alexander Gordeev , Sasha Levin , gor@linux.ibm.com, kees@kernel.org, justinstitt@google.com, linux-s390@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 5/7] s390/sclp: Fix sclp_init() cleanup on failure Date: Tue, 9 Jul 2024 12:27:16 -0400 Message-ID: <20240709162726.33610-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240709162726.33610-1-sashal@kernel.org> References: <20240709162726.33610-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.317 Content-Transfer-Encoding: 8bit From: Heiko Carstens [ Upstream commit 6434b33faaa063df500af355ee6c3942e0f8d982 ] If sclp_init() fails it only partially cleans up: if there are multiple failing calls to sclp_init() sclp_state_change_event will be added several times to sclp_reg_list, which results in the following warning: ------------[ cut here ]------------ list_add double add: new=000003ffe1598c10, prev=000003ffe1598bf0, next=000003ffe1598c10. WARNING: CPU: 0 PID: 1 at lib/list_debug.c:35 __list_add_valid_or_report+0xde/0xf8 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.10.0-rc3 Krnl PSW : 0404c00180000000 000003ffe0d6076a (__list_add_valid_or_report+0xe2/0xf8) R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:0 PM:0 RI:0 EA:3 ... Call Trace: [<000003ffe0d6076a>] __list_add_valid_or_report+0xe2/0xf8 ([<000003ffe0d60766>] __list_add_valid_or_report+0xde/0xf8) [<000003ffe0a8d37e>] sclp_init+0x40e/0x450 [<000003ffe00009f2>] do_one_initcall+0x42/0x1e0 [<000003ffe15b77a6>] do_initcalls+0x126/0x150 [<000003ffe15b7a0a>] kernel_init_freeable+0x1ba/0x1f8 [<000003ffe0d6650e>] kernel_init+0x2e/0x180 [<000003ffe000301c>] __ret_from_fork+0x3c/0x60 [<000003ffe0d759ca>] ret_from_fork+0xa/0x30 Fix this by removing sclp_state_change_event from sclp_reg_list when sclp_init() fails. Reviewed-by: Peter Oberparleiter Signed-off-by: Heiko Carstens Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- drivers/s390/char/sclp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s390/char/sclp.c b/drivers/s390/char/sclp.c index e9aa71cdfc44e..74df353d2244c 100644 --- a/drivers/s390/char/sclp.c +++ b/drivers/s390/char/sclp.c @@ -1206,6 +1206,7 @@ sclp_init(void) fail_unregister_reboot_notifier: unregister_reboot_notifier(&sclp_reboot_notifier); fail_init_state_uninitialized: + list_del(&sclp_state_change_event.list); sclp_init_state = sclp_init_state_uninitialized; fail_unlock: spin_unlock_irqrestore(&sclp_lock, flags); -- 2.43.0