From: "Krzysztof Wilczyński" <kw@linux.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: dan.carpenter@linaro.org,
Krishna chaitanya chundru <quic_krichai@quicinc.com>,
bhelgaas@google.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org,
robh@kernel.org
Subject: Re: [PATCH 2/3] PCI: qcom: Prevent potential error pointer dereference
Date: Wed, 10 Jul 2024 14:43:22 +0900 [thread overview]
Message-ID: <20240710054322.GA3763187@rocinante> (raw)
In-Reply-To: <20240708180539.1447307-3-dan.carpenter@linaro.org>
Hello,
[...]
> > Only call dev_pm_opp_put() if dev_pm_opp_find_freq_exact() succeeds.
> > Otherwise it leads to an error pointer dereference.
> >
> > Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance")
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> Tested-by: Anders Roxell <anders.roxell@linaro.org>
>
> Applied this patch ontop of linux-next tag, next-20240709.
>
> Booted fine on dragonboard-845c HW.
Thank you for testing!
I took the liberty and added your Tested-by: tag to the relevant commits
on our controller/qcom branch.
Krzysztof
next prev parent reply other threads:[~2024-07-10 5:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240708180539.1447307-1-dan.carpenter@linaro.org>
2024-07-08 18:05 ` [PATCH 1/3] PCI: qcom: Fix missing error code in qcom_pcie_probe() Dan Carpenter
2024-07-09 5:11 ` Manivannan Sadhasivam
2024-07-08 18:05 ` [PATCH 2/3] PCI: qcom: Prevent potential error pointer dereference Dan Carpenter
2024-07-09 5:14 ` Manivannan Sadhasivam
2024-07-09 13:59 ` Anders Roxell
2024-07-10 5:43 ` Krzysztof Wilczyński [this message]
2024-07-08 18:05 ` [PATCH 3/3] PCI: qcom: Potential uninitialized variable in qcom_pcie_suspend_noirq() Dan Carpenter
2024-07-09 5:15 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710054322.GA3763187@rocinante \
--to=kw@linux.com \
--cc=anders.roxell@linaro.org \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox