[PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Tengfei Fan]

Introduce support for the QCS9100 SoC device tree (DTSI) and the
QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
While the QCS9100 platform is still in the early design stage, the
QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
mounts the QCS9100 SoC instead of the SA8775p SoC.

The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
all the compatible strings will be updated from "SA8775p" to "QCS9100".
The QCS9100 device tree patches will be pushed after all the device tree
bindings and device driver patches are reviewed.

The final dtsi will like:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/

The detailed cover letter reference:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
Changes in v2:
  - Split huge patch series into different patch series according to
    subsytems
  - Update patch commit message

prevous disscussion here:
[1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

---
Tengfei Fan (2):
      dt-bindings: PCI: Document compatible for QCS9100
      PCI: qcom: Add support for QCS9100 SoC

 Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
 drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
 2 files changed, 5 insertions(+), 1 deletion(-)
---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d

Best regards,
-- 
Tengfei Fan <quic_tengfan@quicinc.com>

[PATCH v2 1/2] dt-bindings: PCI: Document compatible for QCS9100

[Tengfei Fan]

Document compatible for QCS9100 platform.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI
based PCIe.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
index efde49d1bef8..4de33df6963f 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
@@ -16,7 +16,10 @@ description:
 
 properties:
   compatible:
-    const: qcom,pcie-sa8775p
+    items:
+      - enum:
+          - qcom,pcie-qcs9100
+          - qcom,pcie-sa8775p
 
   reg:
     minItems: 6

-- 
2.25.1

[PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC

[Tengfei Fan]

Add support for QCS9100 SoC that uses controller version 5.90
reusing the 1.9.0 config.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,pcie-qcs9100" to the PCIe device
match table.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 26405fcfa499..ea3fddc74498 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1722,6 +1722,7 @@ static const struct of_device_id qcom_pcie_match[] = {
 	{ .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 },
 	{ .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 },
 	{ .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 },
+	{ .compatible = "qcom,pcie-qcs9100", .data = &cfg_sc8280xp },
 	{ .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp },
 	{ .compatible = "qcom,pcie-sa8775p", .data = &cfg_1_34_0},
 	{ .compatible = "qcom,pcie-sc7280", .data = &cfg_1_9_0 },

-- 
2.25.1

Re: [PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC

[Bjorn Helgaas]

On Tue, Jul 09, 2024 at 10:59:30PM +0800, Tengfei Fan wrote:
> Add support for QCS9100 SoC that uses controller version 5.90
> reusing the 1.9.0 config.

Add blank line here if this is a paragraph break.

> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,pcie-qcs9100" to the PCIe device
> match table.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  drivers/pci/controller/dwc/pcie-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 26405fcfa499..ea3fddc74498 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1722,6 +1722,7 @@ static const struct of_device_id qcom_pcie_match[] = {
>  	{ .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 },
>  	{ .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 },
>  	{ .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 },
> +	{ .compatible = "qcom,pcie-qcs9100", .data = &cfg_sc8280xp },
>  	{ .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp },
>  	{ .compatible = "qcom,pcie-sa8775p", .data = &cfg_1_34_0},
>  	{ .compatible = "qcom,pcie-sc7280", .data = &cfg_1_9_0 },
> 
> -- 
> 2.25.1
> 

Re: [PATCH v2 1/2] dt-bindings: PCI: Document compatible for QCS9100

[Bjorn Helgaas]

On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote:
> Document compatible for QCS9100 platform.

Add blank line for paragraph breaks.

> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI
> based PCIe.

Not connected to the patch below.  Move to where it is relevant.

> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> index efde49d1bef8..4de33df6963f 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
> @@ -16,7 +16,10 @@ description:
>  
>  properties:
>    compatible:
> -    const: qcom,pcie-sa8775p
> +    items:
> +      - enum:
> +          - qcom,pcie-qcs9100
> +          - qcom,pcie-sa8775p
>  
>    reg:
>      minItems: 6
> 
> -- 
> 2.25.1
> 

Re: [PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Manivannan Sadhasivam]

On Tue, Jul 09, 2024 at 10:59:28PM +0800, Tengfei Fan wrote:
> Introduce support for the QCS9100 SoC device tree (DTSI) and the
> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> While the QCS9100 platform is still in the early design stage, the
> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> mounts the QCS9100 SoC instead of the SA8775p SoC.
> 
> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> all the compatible strings will be updated from "SA8775p" to "QCS9100".
> The QCS9100 device tree patches will be pushed after all the device tree
> bindings and device driver patches are reviewed.
> 

Are you going to remove SA8775p compatible from all drivers as well?

- Mani

> The final dtsi will like:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
> 
> The detailed cover letter reference:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
> Changes in v2:
>   - Split huge patch series into different patch series according to
>     subsytems
>   - Update patch commit message
> 
> prevous disscussion here:
> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> ---
> Tengfei Fan (2):
>       dt-bindings: PCI: Document compatible for QCS9100
>       PCI: qcom: Add support for QCS9100 SoC
> 
>  Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>  drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
>  2 files changed, 5 insertions(+), 1 deletion(-)
> ---
> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d
> 
> Best regards,
> -- 
> Tengfei Fan <quic_tengfan@quicinc.com>
> 

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Aiqun Yu (Maria)]

On 7/10/2024 1:58 AM, Manivannan Sadhasivam wrote:
> On Tue, Jul 09, 2024 at 10:59:28PM +0800, Tengfei Fan wrote:
>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>> While the QCS9100 platform is still in the early design stage, the
>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>
>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>> The QCS9100 device tree patches will be pushed after all the device tree
>> bindings and device driver patches are reviewed.
>>
> 
> Are you going to remove SA8775p compatible from all drivers as well?

SA8775p compatible and corresponding scmi solutions for the driver will
be taken care from auto team, currently IOT team is adding QCS9100
support only. Auto team have a dependency on the current QCS9100(IOT
non-scmi solution) and SA8775p(AUTO SCMI solution) device tree splitting
effort.

More background and information can be referenced from [1].
[1] v1:
https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> - Mani
> 
>> The final dtsi will like:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>
>> The detailed cover letter reference:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>> Changes in v2:
>>   - Split huge patch series into different patch series according to
>>     subsytems
>>   - Update patch commit message
>>
>> prevous disscussion here:
>> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>
>> ---
>> Tengfei Fan (2):
>>       dt-bindings: PCI: Document compatible for QCS9100
>>       PCI: qcom: Add support for QCS9100 SoC
>>
>>  Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>>  drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
>>  2 files changed, 5 insertions(+), 1 deletion(-)
>> ---
>> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
>> change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d
>>
>> Best regards,
>> -- 
>> Tengfei Fan <quic_tengfan@quicinc.com>
>>
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu

Re: [PATCH v2 1/2] dt-bindings: PCI: Document compatible for QCS9100

[Tengfei Fan]

On 7/10/2024 12:29 AM, Bjorn Helgaas wrote:
> On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote:
>> Document compatible for QCS9100 platform.
> 
> Add blank line for paragraph breaks.

A blank line will be added in the next verion patch series.

> 
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI
>> based PCIe.
> 
> Not connected to the patch below.  Move to where it is relevant.

As mentioned in the cover letter, we will also push the QCS9100 device 
tree patch series to upstream after all the binding and driver patches 
are reviewd. The QCS9100 device tree is directly renamed from the 
SA8775p device tree.

This comment message serves to explain why we need to push this PCIe 
binding patch, thus avoiding any questions from reviews about why we are 
not continuing to use the "qcom,pcie-sa8775p" compatible name.

If you still think that this comment message is not necessay here, I 
will move this comment message from binding and driver patches to the 
cover letter.

> 
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>> index efde49d1bef8..4de33df6963f 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>> @@ -16,7 +16,10 @@ description:
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,pcie-sa8775p
>> +    items:
>> +      - enum:
>> +          - qcom,pcie-qcs9100
>> +          - qcom,pcie-sa8775p
>>   
>>     reg:
>>       minItems: 6
>>
>> -- 
>> 2.25.1
>>

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC

[Tengfei Fan]

On 7/10/2024 12:26 AM, Bjorn Helgaas wrote:
> Add blank line here if this is a paragraph break.

A blank line will be added in the next verion patch series.


-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Manivannan Sadhasivam]

On Wed, Jul 10, 2024 at 09:47:47AM +0800, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/10/2024 1:58 AM, Manivannan Sadhasivam wrote:
> > On Tue, Jul 09, 2024 at 10:59:28PM +0800, Tengfei Fan wrote:
> >> Introduce support for the QCS9100 SoC device tree (DTSI) and the
> >> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
> >> While the QCS9100 platform is still in the early design stage, the
> >> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
> >> mounts the QCS9100 SoC instead of the SA8775p SoC.
> >>
> >> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
> >> all the compatible strings will be updated from "SA8775p" to "QCS9100".
> >> The QCS9100 device tree patches will be pushed after all the device tree
> >> bindings and device driver patches are reviewed.
> >>
> > 
> > Are you going to remove SA8775p compatible from all drivers as well?
> 
> SA8775p compatible and corresponding scmi solutions for the driver will
> be taken care from auto team, currently IOT team is adding QCS9100
> support only. Auto team have a dependency on the current QCS9100(IOT
> non-scmi solution) and SA8775p(AUTO SCMI solution) device tree splitting
> effort.
> 
> More background and information can be referenced from [1].
> [1] v1:
> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/

I'm aware of the background, but what I don't understand is, why do you want to
keep the sa8775p compatible in both the driver and binding? Once you rename the
DT, these compatibles become meaningless.

Waiting for Auto team to remove the compatible is not ideal. They may anyway
modify it based on SCMI design.

- Mani

> > 
> > - Mani
> > 
> >> The final dtsi will like:
> >> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
> >>
> >> The detailed cover letter reference:
> >> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> >>
> >> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> >> ---
> >> Changes in v2:
> >>   - Split huge patch series into different patch series according to
> >>     subsytems
> >>   - Update patch commit message
> >>
> >> prevous disscussion here:
> >> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> >>
> >> ---
> >> Tengfei Fan (2):
> >>       dt-bindings: PCI: Document compatible for QCS9100
> >>       PCI: qcom: Add support for QCS9100 SoC
> >>
> >>  Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
> >>  drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
> >>  2 files changed, 5 insertions(+), 1 deletion(-)
> >> ---
> >> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
> >> change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d
> >>
> >> Best regards,
> >> -- 
> >> Tengfei Fan <quic_tengfan@quicinc.com>
> >>
> > 
> 
> -- 
> Thx and BRs,
> Aiqun(Maria) Yu

-- 
மணிவண்ணன் சதாசிவம்

Re: [PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Aiqun Yu (Maria)]

On 7/10/2024 3:09 PM, Manivannan Sadhasivam wrote:
> On Wed, Jul 10, 2024 at 09:47:47AM +0800, Aiqun Yu (Maria) wrote:
>>
>>
>> On 7/10/2024 1:58 AM, Manivannan Sadhasivam wrote:
>>> On Tue, Jul 09, 2024 at 10:59:28PM +0800, Tengfei Fan wrote:
>>>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>>>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>>>> While the QCS9100 platform is still in the early design stage, the
>>>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>>>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>>>
>>>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>>>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>>>> The QCS9100 device tree patches will be pushed after all the device tree
>>>> bindings and device driver patches are reviewed.
>>>>
>>>
>>> Are you going to remove SA8775p compatible from all drivers as well?
>>
>> SA8775p compatible and corresponding scmi solutions for the driver will
>> be taken care from auto team, currently IOT team is adding QCS9100
>> support only. Auto team have a dependency on the current QCS9100(IOT
>> non-scmi solution) and SA8775p(AUTO SCMI solution) device tree splitting
>> effort.
>>
>> More background and information can be referenced from [1].
>> [1] v1:
>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
> 
> I'm aware of the background, but what I don't understand is, why do you want to
> keep the sa8775p compatible in both the driver and binding? Once you rename the
> DT, these compatibles become meaningless.
> 
> Waiting for Auto team to remove the compatible is not ideal. They may anyway
> modify it based on SCMI design.

Got it. Will remove sa8775p compatible in next patchset version after
discuss with Tengfei.

PCIE driver have a very good shape of resources op api, and when SCMI
resource solution added, "sa8775p" compatible can be added at that time
with correct SCMI resource ops.
> 
> - Mani
> 
>>>
>>> - Mani
>>>
>>>> The final dtsi will like:
>>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>>>
>>>> The detailed cover letter reference:
>>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>>
>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>> ---
>>>> Changes in v2:
>>>>   - Split huge patch series into different patch series according to
>>>>     subsytems
>>>>   - Update patch commit message
>>>>
>>>> prevous disscussion here:
>>>> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>>
>>>> ---
>>>> Tengfei Fan (2):
>>>>       dt-bindings: PCI: Document compatible for QCS9100
>>>>       PCI: qcom: Add support for QCS9100 SoC
>>>>
>>>>  Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>>>>  drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
>>>>  2 files changed, 5 insertions(+), 1 deletion(-)
>>>> ---
>>>> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
>>>> change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d
>>>>
>>>> Best regards,
>>>> -- 
>>>> Tengfei Fan <quic_tengfan@quicinc.com>
>>>>
>>>
>>
>> -- 
>> Thx and BRs,
>> Aiqun(Maria) Yu
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu

Re: [PATCH v2 0/2] PCI: qcom: Add QCS9100 PCIe compatible

[Tengfei Fan]

On 7/10/2024 6:25 PM, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/10/2024 3:09 PM, Manivannan Sadhasivam wrote:
>> On Wed, Jul 10, 2024 at 09:47:47AM +0800, Aiqun Yu (Maria) wrote:
>>>
>>>
>>> On 7/10/2024 1:58 AM, Manivannan Sadhasivam wrote:
>>>> On Tue, Jul 09, 2024 at 10:59:28PM +0800, Tengfei Fan wrote:
>>>>> Introduce support for the QCS9100 SoC device tree (DTSI) and the
>>>>> QCS9100 RIDE board DTS. The QCS9100 is a variant of the SA8775p.
>>>>> While the QCS9100 platform is still in the early design stage, the
>>>>> QCS9100 RIDE board is identical to the SA8775p RIDE board, except it
>>>>> mounts the QCS9100 SoC instead of the SA8775p SoC.
>>>>>
>>>>> The QCS9100 SoC DTSI is directly renamed from the SA8775p SoC DTSI, and
>>>>> all the compatible strings will be updated from "SA8775p" to "QCS9100".
>>>>> The QCS9100 device tree patches will be pushed after all the device tree
>>>>> bindings and device driver patches are reviewed.
>>>>>
>>>>
>>>> Are you going to remove SA8775p compatible from all drivers as well?
>>>
>>> SA8775p compatible and corresponding scmi solutions for the driver will
>>> be taken care from auto team, currently IOT team is adding QCS9100
>>> support only. Auto team have a dependency on the current QCS9100(IOT
>>> non-scmi solution) and SA8775p(AUTO SCMI solution) device tree splitting
>>> effort.
>>>
>>> More background and information can be referenced from [1].
>>> [1] v1:
>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>
>> I'm aware of the background, but what I don't understand is, why do you want to
>> keep the sa8775p compatible in both the driver and binding? Once you rename the
>> DT, these compatibles become meaningless.
>>
>> Waiting for Auto team to remove the compatible is not ideal. They may anyway
>> modify it based on SCMI design.
> 
> Got it. Will remove sa8775p compatible in next patchset version after
> discuss with Tengfei.
> 
> PCIE driver have a very good shape of resources op api, and when SCMI
> resource solution added, "sa8775p" compatible can be added at that time
> with correct SCMI resource ops.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

>>
>> - Mani
>>
>>>>
>>>> - Mani
>>>>
>>>>> The final dtsi will like:
>>>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-3-quic_tengfan@quicinc.com/
>>>>>
>>>>> The detailed cover letter reference:
>>>>> https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>>>
>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>>> ---
>>>>> Changes in v2:
>>>>>    - Split huge patch series into different patch series according to
>>>>>      subsytems
>>>>>    - Update patch commit message
>>>>>
>>>>> prevous disscussion here:
>>>>> [1] v1: https://lore.kernel.org/linux-arm-msm/20240703025850.2172008-1-quic_tengfan@quicinc.com/
>>>>>
>>>>> ---
>>>>> Tengfei Fan (2):
>>>>>        dt-bindings: PCI: Document compatible for QCS9100
>>>>>        PCI: qcom: Add support for QCS9100 SoC
>>>>>
>>>>>   Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>>>>>   drivers/pci/controller/dwc/pcie-qcom.c                       | 1 +
>>>>>   2 files changed, 5 insertions(+), 1 deletion(-)
>>>>> ---
>>>>> base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
>>>>> change-id: 20240709-add_qcs9100_pcie_compatible-ceec013a335d
>>>>>
>>>>> Best regards,
>>>>> -- 
>>>>> Tengfei Fan <quic_tengfan@quicinc.com>
>>>>>
>>>>
>>>
>>> -- 
>>> Thx and BRs,
>>> Aiqun(Maria) Yu
>>
> 

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 1/2] dt-bindings: PCI: Document compatible for QCS9100

[Tengfei Fan]

On 7/10/2024 2:37 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 12:29 AM, Bjorn Helgaas wrote:
>> On Tue, Jul 09, 2024 at 10:59:29PM +0800, Tengfei Fan wrote:
>>> Document compatible for QCS9100 platform.
>>
>> Add blank line for paragraph breaks.
> 
> A blank line will be added in the next verion patch series.
> 
>>
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcom,pcie-qcs9100" to describe non-SCMI
>>> based PCIe.
>>
>> Not connected to the patch below.  Move to where it is relevant.
> 
> As mentioned in the cover letter, we will also push the QCS9100 device 
> tree patch series to upstream after all the binding and driver patches 
> are reviewd. The QCS9100 device tree is directly renamed from the 
> SA8775p device tree.
> 
> This comment message serves to explain why we need to push this PCIe 
> binding patch, thus avoiding any questions from reviews about why we are 
> not continuing to use the "qcom,pcie-sa8775p" compatible name.
> 
> If you still think that this comment message is not necessay here, I 
> will move this comment message from binding and driver patches to the 
> cover letter.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 
>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml 
>>> b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>>> index efde49d1bef8..4de33df6963f 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-sa8775p.yaml
>>> @@ -16,7 +16,10 @@ description:
>>>   properties:
>>>     compatible:
>>> -    const: qcom,pcie-sa8775p
>>> +    items:
>>> +      - enum:
>>> +          - qcom,pcie-qcs9100
>>> +          - qcom,pcie-sa8775p
>>>     reg:
>>>       minItems: 6
>>>
>>> -- 
>>> 2.25.1
>>>
> 

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC

[Tengfei Fan]

On 7/10/2024 2:38 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 12:26 AM, Bjorn Helgaas wrote:
>> Add blank line here if this is a paragraph break.
> 
> A blank line will be added in the next verion patch series.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 
> 

-- 
Thx and BRs,
Tengfei Fan