From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B61FB18FA39; Wed, 10 Jul 2024 11:51:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720612307; cv=none; b=BYuNgbG8oI4rdrZ/Bq7k4fXdsIThUYMplUgPXL/4KO45wnxSybR2P7scglZPMnoQlmNPidE8vgYArjpkvgR6bfHYvlwVDqnxtxq8cmkKjYxcT172iV92JlnXF4L5vA2pV1MhvX4W53oJpqRZQas+ZMCU8SyAJnAXN0QhuxdIZxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720612307; c=relaxed/simple; bh=+8Hn6GirerIMLeoeogts/cGCrU1jbWtvtugPsuhHr8Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rGiqygYyCLO137luLYGTR6nHjxqjoxvpwezy6QbZevcLNua1sIW0KbfXewqVjQsgNXElzpkvMOKod6xlKCnxBDmzzePaUhq1o7UHzRc6UIyXws3frtl8qRCBxj3qqRPOSpLGc/IOlIK1BDj/TGXQqIK3oQP+JKrvVmKvLUmpbrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=mjm0Ft4j; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="mjm0Ft4j" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 926EBC32781; Wed, 10 Jul 2024 11:51:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1720612307; bh=+8Hn6GirerIMLeoeogts/cGCrU1jbWtvtugPsuhHr8Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mjm0Ft4jZI39dqIpTr6DOyr1YfcrZd+bvWZvDz07VCTPvnit+IvmONgtvltSco4nR SX4UlRX2si4Xz1ipLGKhC4FY/lV1OvD+MJNQeYxn6bapyyEvMD3BP7HigJitmRrrAv 0Xmj4H52NNyK6kQnjDFCEfUvgYvvBb8/aFzBd3TQ= Date: Wed, 10 Jul 2024 13:51:44 +0200 From: Greg Kroah-Hartman To: Akash Kumar Cc: Thinh Nguyen , Jing Leng , Felipe Balbi , Jack Pham , kernel@quicinc.com, Wesley Cheng , Laurent Pinchart , Daniel Scally , Vijayavardhan Vennapusa , Krishna Kurapati , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: uvc: Add H264 frame format support Message-ID: <2024071054-anatomist-purchase-1e98@gregkh> References: <20240708041328.1942-1-quic_akakum@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240708041328.1942-1-quic_akakum@quicinc.com> On Mon, Jul 08, 2024 at 09:43:28AM +0530, Akash Kumar wrote: > Add support for framebased frame format which can be used to support > multiple formats like H264 or H265 other than mjpeg and YUV frames. > > Framebased format is set to H264 by default, which can be updated to > other formats by updating the GUID through guid configfs attribute. > > Signed-off-by: Akash Kumar > --- > drivers/usb/gadget/function/uvc_configfs.c | 570 ++++++++++++++++++--- > drivers/usb/gadget/function/uvc_configfs.h | 34 +- > drivers/usb/gadget/function/uvc_v4l2.c | 80 ++- > include/uapi/linux/usb/video.h | 62 +++ > 4 files changed, 638 insertions(+), 108 deletions(-) DOn't you need to add the new configfs entries to Documentation/ABI/? And how is anyone going to know about this new api or format if there are not new files? WHere is it now documented? thanks, greg k-h