Re: [PATCH v2 01/11] perf/uprobe: Re-indent labels

Jiri Olsa
2024-07-11T11:58:09Z

On Thu, Jul 11, 2024 at 01:02:36PM +0200, Peter Zijlstra wrote:

SNIP

> @@ -1159,7 +1159,7 @@ static int __uprobe_register(struct inod
> if (!IS_ALIGNED(ref_ctr_offset, sizeof(short)))
> return -EINVAL;
>
> - retry:
> +retry:
> uprobe = alloc_uprobe(inode, offset, ref_ctr_offset);
> if (!uprobe)
> return -ENOMEM;
> @@ -1468,7 +1468,7 @@ static int xol_add_vma(struct mm_struct
> ret = 0;
> /* pairs with get_xol_area() */
> smp_store_release(&mm->uprobes_state.xol_area, area); /* ^^^ */
> - fail:
> +fail:
> mmap_write_unlock(mm);
>
> return ret;
> @@ -1512,7 +1512,7 @@ static struct xol_area *__create_xol_are
> kfree(area->bitmap);
> free_area:

hi,
missed this one and another one few lines before that ;-)

jirka

> kfree(area);
> - out:
> +out:
> return NULL;
> }
>
> @@ -1915,7 +1915,7 @@ static void prepare_uretprobe(struct upr
> utask->return_instances = ri;
>
> return;
> - fail:
> +fail:
> kfree(ri);
> }
>
> @@ -2031,7 +2031,7 @@ static int is_trap_at_addr(struct mm_str
>
> copy_from_page(page, vaddr, &opcode, UPROBE_SWBP_INSN_SIZE);
> put_page(page);
> - out:
> +out:
> /* This needs to return true for any variant of the trap insn */
> return is_trap_insn(&opcode);
> }
> @@ -2159,7 +2159,7 @@ static void handle_trampoline(struct pt_
> utask->return_instances = ri;
> return;
>
> - sigill:
> +sigill:
> uprobe_warn(current, "handle uretprobe, sending SIGILL.");
> force_sig(SIGILL);
>
>
>