Re: [PATCH v2 08/11] perf/uprobe: Convert (some) uprobe->refcount to SRCU

Jiri Olsa
2024-07-11T14:03:42Z

On Thu, Jul 11, 2024 at 01:02:43PM +0200, Peter Zijlstra wrote:

SNIP

> /* Tracing handlers use ->utask to communicate with fetch methods */
> if (!get_utask())
> - goto out;
> + return;
>
> if (arch_uprobe_ignore(&uprobe->arch, regs))
> - goto out;
> + return;
>
> handler_chain(uprobe, regs);
>
> if (arch_uprobe_skip_sstep(&uprobe->arch, regs))
> - goto out;
> -
> - if (!pre_ssout(uprobe, regs, bp_vaddr))
> return;
>
> - /* arch_uprobe_skip_sstep() succeeded, or restart if can't singlestep */
> -out:
> - put_uprobe(uprobe);
> + pre_ssout(uprobe, regs, bp_vaddr);

pre_ssout could now return void

jirka

> }
>
> /*
>
>