Re: [PATCH v3 2/2] clk: samsung: gs101: don't mark non-essential (UART) clocks critical

André Draszik
2024-07-12T05:00:22Z

On Wed, 2024-07-10 at 16:35 +0200, Marek Szyprowski wrote:
> I think that it would be much better to check if earlycon is specified
> in kernel's cmdline and if so, simply mark those problematic clocks
> critical in this driver. Make this code hidden under
> IS_ENABLED(CONFIG_SERIAL_EARLYCON) to avoid polluting release builds.
> Any comments?

Good idea, I've found that i.MX appears to suffer from a similar problem,
and I'm testing something similar now:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/imx/clk.c#n157

Cheers,
Andre'