From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev
Subject: Re: [PATCH 2/2] dma: Add IOMMU static calls with clear default ops
Date: Fri, 12 Jul 2024 09:02:55 +0300 [thread overview]
Message-ID: <20240712060255.GF1815706@unreal> (raw)
In-Reply-To: <20240712044937.GA4709@lst.de>
On Fri, Jul 12, 2024 at 06:49:37AM +0200, Christoph Hellwig wrote:
> On Thu, Jul 11, 2024 at 07:23:20PM +0100, Robin Murphy wrote:
> > If so, I'd much rather see this done properly, i.e. hook everything up
> > similarly to dma-direct and be able to drop CONFIG_DMA_OPS for "modern"
> > dma-direct/iommu-dma architectures entirely.
>
> Yes. That is much better than doing hacks based on missing ops.
There is nothing wrong to do conversion to iommu direct in the steps.
The first step is to add the dma-iommu calls with if (!..) checks,
so everyone will get better performance right now. The second step
is to remove the if (!..) checks together with dummy ops.
Thanks
>
> Note that the media subsystems just added another abuse of dma_map_ops
> in drivers/ in addition to the existing vdpa one that we'll need to
> kill again to fully get rid of dma_map_ops for common setups (in
> addition to merging swiotlb-xen into main swiotlb finally).
>
next prev parent reply other threads:[~2024-07-12 6:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 10:38 [PATCH 1/2] dma: call unconditionally to unmap_page and unmap_sg callbacks Leon Romanovsky
2024-07-11 10:38 ` [PATCH 2/2] dma: Add IOMMU static calls with clear default ops Leon Romanovsky
2024-07-11 17:27 ` Leon Romanovsky
2024-07-11 18:17 ` Easwar Hariharan
2024-07-11 18:45 ` Leon Romanovsky
2024-07-11 18:23 ` Robin Murphy
2024-07-11 18:57 ` Leon Romanovsky
2024-07-11 20:08 ` Robin Murphy
2024-07-12 5:50 ` Leon Romanovsky
2024-07-12 14:21 ` Robin Murphy
2024-07-13 5:18 ` Christoph Hellwig
2024-07-13 9:32 ` Leon Romanovsky
2024-07-12 4:49 ` Christoph Hellwig
2024-07-12 6:02 ` Leon Romanovsky [this message]
2024-07-12 20:51 ` Easwar Hariharan
2024-07-13 9:30 ` Leon Romanovsky
2024-07-11 18:02 ` [PATCH 1/2] dma: call unconditionally to unmap_page and unmap_sg callbacks Robin Murphy
2024-07-12 5:47 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712060255.GF1815706@unreal \
--to=leon@kernel.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox