From: Ankit Agrawal <agrawal.ag.ankit@gmail.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error when reading clock frequency.
Date: Fri, 12 Jul 2024 14:06:57 +0530 [thread overview]
Message-ID: <20240712083657.GA182712@bnew-VirtualBox> (raw)
In-Reply-To: <069282eb-d891-4537-bdc0-85de17b5e61f@linaro.org>
On Thu, Jul 11, 2024 at 10:13:38AM +0200, Konrad Dybcio wrote:
> On 11.07.2024 10:11 AM, Konrad Dybcio wrote:
> > On 11.07.2024 7:49 AM, Ankit Agrawal wrote:
> >> On Wed, Jul 10, 2024 at 01:54:01PM +0200, Konrad Dybcio wrote:
> >>> On 10.07.2024 1:08 PM, Ankit Agrawal wrote:
[...]
>
> We should probably also check if msm_timer_init() succeeds and unmap
> if that fails.. we can just check the return value of that function
> and if it's non-zero, call iounmap
Sure. I have updated the patch accordingly. Please find version 2 of the
patch here: https://lore.kernel.org/linux-arm-msm/20240712082747.GA182658@bnew-VirtualBox/
Thanks!
Ankit
prev parent reply other threads:[~2024-07-12 8:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 11:08 [PATCH] drivers/clocksource/qcom: Add missing iounmap() on error when reading clock frequency Ankit Agrawal
2024-07-10 11:54 ` Konrad Dybcio
2024-07-11 5:49 ` Ankit Agrawal
2024-07-11 8:11 ` Konrad Dybcio
2024-07-11 8:13 ` Konrad Dybcio
2024-07-12 8:36 ` Ankit Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712083657.GA182712@bnew-VirtualBox \
--to=agrawal.ag.ankit@gmail.com \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox