From: Jason Gunthorpe <jgg@ziepe.ca>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iommufd: Add check on user response code
Date: Fri, 12 Jul 2024 09:43:11 -0300 [thread overview]
Message-ID: <20240712124311.GY14050@ziepe.ca> (raw)
In-Reply-To: <b4758476-6de2-4d3e-91b2-10599a37d00e@linux.intel.com>
On Fri, Jul 12, 2024 at 10:54:11AM +0800, Baolu Lu wrote:
> diff --git a/drivers/iommu/iommufd/fault.c b/drivers/iommu/iommufd/fault.c
> index 29f522819759..a643d5c7c535 100644
> --- a/drivers/iommu/iommufd/fault.c
> +++ b/drivers/iommu/iommufd/fault.c
> @@ -305,10 +305,10 @@ static ssize_t iommufd_fault_fops_write(struct file
> *filep, const char __user *b
> if (rc)
> break;
>
> - static_assert(IOMMUFD_PAGE_RESP_SUCCESS ==
> - IOMMU_PAGE_RESP_SUCCESS);
> - static_assert(IOMMUFD_PAGE_RESP_INVALID ==
> - IOMMU_PAGE_RESP_INVALID);
> + static_assert((int)IOMMUFD_PAGE_RESP_SUCCESS ==
> + (int)IOMMU_PAGE_RESP_SUCCESS);
> + static_assert((int)IOMMUFD_PAGE_RESP_INVALID ==
> + (int)IOMMU_PAGE_RESP_INVALID);
> if (response.code != IOMMUFD_PAGE_RESP_SUCCESS &&
> response.code != IOMMUFD_PAGE_RESP_INVALID) {
> rc = -EINVAL;
Yep, my compiler doesn't warn on that apparently..
Jason
next prev parent reply other threads:[~2024-07-12 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 8:33 [PATCH 0/3] iommufd: Avoid PRI Response Failure Lu Baolu
2024-07-10 8:33 ` [PATCH 1/3] iommufd: Remove IOMMUFD_PAGE_RESP_FAILURE Lu Baolu
2024-07-10 9:45 ` Tian, Kevin
2024-07-10 8:33 ` [PATCH 2/3] iommufd: Add check on user response code Lu Baolu
2024-07-10 9:47 ` Tian, Kevin
2024-07-11 23:39 ` Jason Gunthorpe
2024-07-12 2:54 ` Baolu Lu
2024-07-12 12:43 ` Jason Gunthorpe [this message]
2024-07-10 8:33 ` [PATCH 3/3] iommu: Convert response code from failure to invalid Lu Baolu
2024-07-10 9:56 ` Tian, Kevin
2024-07-11 4:42 ` Baolu Lu
2024-07-11 23:37 ` Jason Gunthorpe
2024-07-11 23:45 ` [PATCH 0/3] iommufd: Avoid PRI Response Failure Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240712124311.GY14050@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox