Re: [PATCH net-next] selftests: mptcp: lib: fix shellcheck errors

Matthieu Baerts
2024-07-15T09:07:31Z

Hi Jakub,

On 14/07/2024 00:46, Jakub Kicinski wrote:
> On Fri, 12 Jul 2024 12:00:15 +0200 Matthieu Baerts (NGI0) wrote:
>> It looks like we missed these two errors recently:
>>
>> - SC2068: Double quote array expansions to avoid re-splitting elements.
>> - SC2145: Argument mixes string and array. Use * or separate argument.
>>
>> Two simple fixes, it is not supposed to change the behaviour as the
>> variable names should not have any spaces in their names. Still, better
>> to fix them to easily spot new issues.
>>
>> Fixes: f265d3119a29 ("selftests: mptcp: lib: use setup/cleanup_ns helpers")
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> Speaking of MPTCP tests - I added the connect test to ignored today.
> Too many failures :(

Sorry for that, and thank you for having ignore it for the 'dbg' runner.

This sudden regression looks strange. Our CI didn't catch this issue so
far. It is only happening with the debug kernel config.

Do you know if anything has changed recently -- around the 11th of July
-- on NIPA's config side that is not documented? e.g. more jobs in
parallel, new kernel config? I didn't see anything that could cause the
new issues when looking at NIPA's git log and the CI change log sheet.

I will try to reproduce the issue locally, maybe it is caused by a patch
that is in patchwork, but not in net or net-next yet.

Cheers,
Matt
--