public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, weh@microsoft.com,
	sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: indicate that inline data is not supported
Date: Tue, 16 Jul 2024 14:14:41 +0300	[thread overview]
Message-ID: <20240716111441.GB5630@unreal> (raw)
In-Reply-To: <1721126889-22770-1-git-send-email-kotaranov@linux.microsoft.com>

On Tue, Jul 16, 2024 at 03:48:09AM -0700, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Set max_inline_data to zero during RC QP creation.
> 
> Fixes: fdefb9184962 ("RDMA/mana_ib: Implement uapi to create and destroy RC QP")
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
>  drivers/infiniband/hw/mana/qp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/mana/qp.c b/drivers/infiniband/hw/mana/qp.c
> index 73d67c853b6f..d9f24a763e72 100644
> --- a/drivers/infiniband/hw/mana/qp.c
> +++ b/drivers/infiniband/hw/mana/qp.c
> @@ -426,6 +426,8 @@ static int mana_ib_create_rc_qp(struct ib_qp *ibqp, struct ib_pd *ibpd,
>  	u64 flags = 0;
>  	u32 doorbell;
>  
> +	/* inline data is not supported */
> +	attr->cap.max_inline_data = 0;

Can you please point to me to the flow where attr is not zeroed before?

Thanks

>  	if (!udata || udata->inlen < sizeof(ucmd))
>  		return -EINVAL;
>  
> -- 
> 2.43.0
> 

  reply	other threads:[~2024-07-16 11:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 10:48 [PATCH rdma-next 1/1] RDMA/mana_ib: indicate that inline data is not supported Konstantin Taranov
2024-07-16 11:14 ` Leon Romanovsky [this message]
2024-07-16 13:42   ` Konstantin Taranov
2024-07-16 14:22     ` Leon Romanovsky
2024-07-16 14:55       ` Konstantin Taranov
2024-07-16 17:06         ` Leon Romanovsky
2024-07-16 17:25           ` [EXTERNAL] " Konstantin Taranov
2024-07-17  6:22             ` Leon Romanovsky
2024-07-17 16:34               ` Jason Gunthorpe
2024-07-18 15:05                 ` Konstantin Taranov
2024-07-18 16:48                   ` Jason Gunthorpe
2024-07-19 10:51                     ` Konstantin Taranov
2024-07-21  6:56                       ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716111441.GB5630@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kotaranov@linux.microsoft.com \
    --cc=kotaranov@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=sharmaajay@microsoft.com \
    --cc=weh@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox