Re: [PATCH 06/15] net: hbl_cn: debugfs support

Andrew Lunn
2024-12-17T10:52:14Z

On Tue, Dec 17, 2024 at 12:00:39PM +0200, Avri Kehat wrote:
> Revisiting the comments regarding our use of debugfs as an interface for device configurations -
> A big part of the non-statistics debugfs parameters are HW related debug-only capabilities, and not configurations required by the user.
> Should these sort of parameters be part of devlink as well?
> Is there another location where debug related configurations for development can reside in?

There are a few options:

If the user does not require them, don't even implement them. If the
user is not using them, who is?

Implement them in an out of tree patch, which your development team
can use, since these are not user configuration options.

devlink is a possibility, but developers complain it is slow to get
them merged since we want to understand what the configuration option
does, why would i want to use it, would any other vendor have the same
need, and should it be made generic etc.

You could join those asking for fwctl, which is a contentious subject.

Andrew