Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

Przemek Kitszel
2024-06-13T14:16:54Z

On 6/13/24 15:01, Przemek Kitszel wrote:
> On 6/13/24 10:21, Omer Shpigelman wrote:

[...]

>> +
>> +int hbl_cn_read_spmu_counters(struct hbl_cn_port *cn_port, u64
>> out_data[], u32 *num_out_data)
>> +{
>> +    struct hbl_cn_device *hdev = cn_port->hdev;
>> +    struct hbl_cn_asic_port_funcs *port_funcs;
>> +    struct hbl_cn_stat *ignore;
>> +    int rc;
>> +
>> +    port_funcs = hdev->asic_funcs->port_funcs;
>> +
>> +    port_funcs->spmu_get_stats_info(cn_port, &ignore, num_out_data);
>
> hard to ignore that you deref uninitialized pointer...

oh, sorry, I was in hurry, please disregard this particular comment

>
> please consider going one step back and start with our internal mailing
> lists, thank you
> Przemek

but this option very much still holds

>
> [...]
>