Re: [PATCH 11/15] RDMA/hbl: add habanalabs RDMA driver

Przemek Kitszel
2024-06-18T16:01:29Z

On 6/18/24 13:08, Omer Shpigelman wrote:
> On 6/17/24 22:04, Leon Romanovsky wrote:
>> [Some people who received this message don't often get email from leon@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> On Mon, Jun 17, 2024 at 05:43:49PM +0000, Omer Shpigelman wrote:
>>> On 6/13/24 22:18, Leon Romanovsky wrote:
>>>> [Some people who received this message don't often get email from leon@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>>
>>>> On Thu, Jun 13, 2024 at 11:22:04AM +0300, Omer Shpigelman wrote:
>>>>> Add an RDMA driver of Gaudi ASICs family for AI scaling.
>>>>> The driver itself is agnostic to the ASIC in action, it operates according
>>>>> to the capabilities that were passed on device initialization.
>>>>> The device is initialized by the hbl_cn driver via auxiliary bus.
>>>>> The driver also supports QP resource tracking and port/device HW counters.
>>>>>
>>>>> Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
>>>>> Co-developed-by: Abhilash K V <kvabhilash@habana.ai>
>>>>> Signed-off-by: Abhilash K V <kvabhilash@habana.ai>
>>>>> Co-developed-by: Andrey Agranovich <aagranovich@habana.ai>
>>>>> Signed-off-by: Andrey Agranovich <aagranovich@habana.ai>
>>>>> Co-developed-by: Bharat Jauhari <bjauhari@habana.ai>
>>>>> Signed-off-by: Bharat Jauhari <bjauhari@habana.ai>
>>>>> Co-developed-by: David Meriin <dmeriin@habana.ai>
>>>>> Signed-off-by: David Meriin <dmeriin@habana.ai>
>>>>> Co-developed-by: Sagiv Ozeri <sozeri@habana.ai>
>>>>> Signed-off-by: Sagiv Ozeri <sozeri@habana.ai>
>>>>> Co-developed-by: Zvika Yehudai <zyehudai@habana.ai>
>>>>> Signed-off-by: Zvika Yehudai <zyehudai@habana.ai>
>>>>
>>>> I afraid that you misinterpreted the "Co-developed-by" tag. All these
>>>> people are probably touch the code and not actually sit together at
>>>> the same room and write the code together. So, please remove the
>>>> extensive "Co-developed-by" tags.
>>>>
>>>> It is not full review yet, but simple pass-by-comments.
>>>>
>>>
>>> Actually except of two, all of the mentioned persons sat in the same room
>>> and developed the code together.
>>> The remaining two are located on a different site (but also together).
>>> Isn't that what "Co-developed-by" tag for?
>>> I wanted to give them credit for writing the code but I can remove if it's
>>> not common.
>>
>> Signed-off-by will be enough to give them credit.
>>
>
> Ok, good enough.
>

I would say that a lone sign-off give a little of credit compared to the
co-developed-by tag. OTOH the list here is unusually long. What makes it
even more tricky to evaluate is the fact that there is a lot of code ;)

So, I would suggest to re-evaluate this on your next (trimmed down)
revisions.