Re: [PATCH 06/15] net: hbl_cn: debugfs support

Omer Shpigelman
2024-06-23T07:26:32Z

On 6/21/24 13:30, Sunil Kovvuri Goutham wrote:
>>>> +
>>>> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_disable_decap
>>>> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_inject_rx_err
>>>> +What:
>> /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_lane_remap
>>>
>>> Don't think debugfs is the correct interface for all this configuration.
>>> Debugfs should ideally be used for dumping runtime device state info for debug
>> purposes.
>>>
>>
>> I see other vendors have debugfs entries for debug configurations or settings, not
>> just for dumping debug info.
>>
>
> But disable_decap / mac_lane_remap seems configuration related which changes the way pkts are processed not debug.
> Configurations are supported via devlink.
>

As I wrote to Andrew, I'll stick to the debugfs entries that are really
necessary for us.
BTW the entries you mentioned are not regular configurations but advanced
settings to augment debuggability. But yeah, if we can set these via
devlink then it is better to use it.
Let me revisit this for the next patch set version.

> Thanks,
> Sunil.