RE: [PATCH 06/15] net: hbl_cn: debugfs support

Sunil Kovvuri Goutham
2024-06-21T10:30:40Z

>>> +
>>> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_disable_decap
>>> +What: /sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_inject_rx_err
>>> +What:
>/sys/kernel/debug/habanalabs_cn/hbl_cn<n>/nic_mac_lane_remap
>>
>> Don't think debugfs is the correct interface for all this configuration.
>> Debugfs should ideally be used for dumping runtime device state info for debug
>purposes.
>>
>
>I see other vendors have debugfs entries for debug configurations or settings, not
>just for dumping debug info.
>

But disable_decap / mac_lane_remap seems configuration related which changes the way pkts are processed not debug.
Configurations are supported via devlink.

Thanks,
Sunil.