Re: [PATCH 01/15] net: hbl_cn: add habanalabs Core Network driver

Leon Romanovsky
2024-06-17T11:48:23Z

On Mon, Jun 17, 2024 at 08:08:26AM +0000, Omer Shpigelman wrote:
> On 6/13/24 16:01, Przemek Kitszel wrote:
> > [Some people who received this message don't often get email from przemyslaw.kitszel@intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> >
> > On 6/13/24 10:21, Omer Shpigelman wrote:
> >> Add the hbl_cn driver which will serve both Ethernet and InfiniBand
> >> drivers.
> >> hbl_cn is the layer which is used by the satellite drivers for many shared
> >> operations that are needed by both EN and IB subsystems like QPs, CQs etc.
> >> The CN driver is initialized via auxiliary bus by the habanalabs driver.
> >>
> >> Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
> >> Co-developed-by: Abhilash K V <kvabhilash@habana.ai>
> >> Signed-off-by: Abhilash K V <kvabhilash@habana.ai>
> >> Co-developed-by: Andrey Agranovich <aagranovich@habana.ai>
> >> Signed-off-by: Andrey Agranovich <aagranovich@habana.ai>
> >> Co-developed-by: Bharat Jauhari <bjauhari@habana.ai>
> >> Signed-off-by: Bharat Jauhari <bjauhari@habana.ai>
> >> Co-developed-by: David Meriin <dmeriin@habana.ai>
> >> Signed-off-by: David Meriin <dmeriin@habana.ai>
> >> Co-developed-by: Sagiv Ozeri <sozeri@habana.ai>
> >> Signed-off-by: Sagiv Ozeri <sozeri@habana.ai>
> >> Co-developed-by: Zvika Yehudai <zyehudai@habana.ai>
> >> Signed-off-by: Zvika Yehudai <zyehudai@habana.ai>
> >> ---
> >> .../device_drivers/ethernet/index.rst | 1 +
> >> .../device_drivers/ethernet/intel/hbl.rst | 82 +
> >> MAINTAINERS | 11 +
> >> drivers/net/ethernet/intel/Kconfig | 20 +
> >> drivers/net/ethernet/intel/Makefile | 1 +
> >> drivers/net/ethernet/intel/hbl_cn/Makefile | 9 +
> >> .../net/ethernet/intel/hbl_cn/common/Makefile | 3 +
> >> .../net/ethernet/intel/hbl_cn/common/hbl_cn.c | 5954 +++++++++++++++++
> >> .../net/ethernet/intel/hbl_cn/common/hbl_cn.h | 1627 +++++
> >> .../ethernet/intel/hbl_cn/common/hbl_cn_drv.c | 220 +
> >> .../intel/hbl_cn/common/hbl_cn_memory.c | 40 +
> >> .../ethernet/intel/hbl_cn/common/hbl_cn_phy.c | 33 +
> >> .../ethernet/intel/hbl_cn/common/hbl_cn_qp.c | 13 +
> >> include/linux/habanalabs/cpucp_if.h | 125 +-
> >> include/linux/habanalabs/hl_boot_if.h | 9 +-
> >> include/linux/net/intel/cn.h | 474 ++
> >> include/linux/net/intel/cn_aux.h | 298 +
> >> include/linux/net/intel/cni.h | 636 ++
> >> 18 files changed, 9545 insertions(+), 11 deletions(-)
> >
> > this is a very big patch, it asks for a split; what's worse, it's
> > proportional to the size of this series:
> > 146 files changed, 148514 insertions(+), 70 deletions(-)
> > which is just too big
> >
> > [...]
> >
>
> Yeah, well I'm limited to 15 patches per patch set according to the kernel
> doc so I had to have this big patch.
> Our changes are contained in 4 different drivers and all of the changes
> should be merged together so the HW will be operational.
> Hence I had to squeeze some code to a big patch.

Submit your code in multiple steps. One driver at a time.

Thanks